Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msgbox shimmy when typing new message #3900

Closed
dbushong opened this issue Aug 3, 2016 · 4 comments · Fixed by #3986
Closed

msgbox shimmy when typing new message #3900

dbushong opened this issue Aug 3, 2016 · 4 comments · Fixed by #3986

Comments

@dbushong
Copy link
Contributor

dbushong commented Aug 3, 2016

Your Rocket.Chat version: 0.36.0

When you type the first char into the msg box for a new msg, the attachment icon shifts (something w/ flexbox css?) - it's super-distracting:

shimmy

@danieldafoe
Copy link

danieldafoe commented Aug 3, 2016

@dbushong What browser/device are you using?

I cannot reproduce using these so far:

  • Safari 10.0, OSX
  • Chrome 51.0.2704.103, OSX
  • Firefox 44.0.2 and 47.0, OSX
  • IE11, Windows 8.1
  • IE10, Windows 7

@dbushong
Copy link
Contributor Author

dbushong commented Aug 3, 2016

Chrome macOS & Electron macOS client. Confirmed by other people using my same server - let me know if you want an acct. Confirmed that I do not see it in the same browser on https://demo.rocket.chat/

Forgot to mention that only saw this after 0.35 -> 0.36 upgrade (did full cache clears in the browser just to make sure all CSS updated) I do have some custom site CSS, but I wiped it and still saw the same problem (again after cache clear)

I'll try to figure out what's different between mine & demo site to hunt this down.

@dbushong
Copy link
Contributor Author

dbushong commented Aug 3, 2016

Ah hah, the difference is that the demo site never shows the video chat button.

It's this disappearing when you start typing that's causing the shimmy, somehow.

@dbushong
Copy link
Contributor Author

dbushong commented Aug 3, 2016

Confirmed, if you disable "Admin > Messages > Video Recorder Enabled" the problem "goes away"

rodrigok pushed a commit that referenced this issue Aug 13, 2016
@marceloschmidt marceloschmidt modified the milestone: 0.37.0 Sep 5, 2016
syzer added a commit to syzer/Rocket.Chat that referenced this issue Sep 9, 2016
* Show notification for non focused rooms

* Ignore **/.meteor/dev_bundle

* Close RocketChat#3783; Allow guest users to view joined direct rooms

* Slackbridge-import

* SlackBridge Import working with files now

* no message

* Add extention to filename if not included in download file (RocketChat#3914)

* Closes RocketChat#3183

* Use mime-types npm package for mime2ext

* refactor code

* Closes RocketChat#3937; Prevent selfmade notifications

* Added crowd integration (RocketChat#3852)

* Added crowd integration

* eslint fixes

* Added test connection, fixed some issues

* Addition of location share feature (RocketChat#3924)

* added new mapview package, added code to handle location share button

* added rocketchat:mapview to active packages

* updates to MapView package to support google static maps

* updated link target to blank page

* changed location button to depend on settings

* corrected eslint, changed var names

* updates to settings code

* changed maps link to navigate link for android+ios support

* stripped trailing spaces

* moved mapview files into subfolders under package

* added focus event back to location button

* add i18n entries to en file, update settings with i18n keys

* add modal confirmation of location share, moved location to geojson property under the Message model

* https://docs.mongodb.com/manual/core/2dsphere/ -> 2dsphere indexes are sparse by default and ignores the sparse: true option.

* button depends on location API being available. Tested in Chrome, Chrome Mobile, and Cordova Rocket.Chat from Store.

* Removed unnecessary translations

* Bump appVersion

* update default setting for file upload types

* fix for issue RocketChat#3953

* Tweaked markdown regex for [text](URI) to ignore close parethesis characters inside the URI

* Fix regression of iFrame login

* Fix link "go to message" on emails

- Gets the link based on room type using user's subscription data
- Do not loop over subscriptions for rooms without custom link

* Improve geolocation button

* Fix video record regex

* Closes RocketChat#3771; Fix some oembed issues

* Remove package mdg:geolocation

* Bugfix: Could not login when the CROWD disabled and LDAP enabled (RocketChat#3974)

* Prevent last admin removal (RocketChat#3971)

* More admin checks

# Conflicts:
#	packages/rocketchat-lib/server/methods/insertOrUpdateUser.coffee

* missing server side validation

# Conflicts:
#	packages/rocketchat-ui-flextab/flex-tab/tabs/userEdit.coffee

* Remove last admin check for removeUserFromRoom

* Move and fix last admin check for role removal

Check was on change admin status method, but that didn’t catch direct removal of user from role admin view.

* Fix last admin check for insert/update/delete user

Was checking if only one admin but not if the updated user was admin, preventing all updates.

* Allow translation of last admin error

* Fix assigning admin permission bypass

* Update side-nav with room counts (RocketChat#3967)

* update side-nav with room counts

* removed unused styles

* Revert "Tweaked markdown regex for [text](URI) to ignore close parentheses" (RocketChat#3976)

* Fix livechat webhook infinite retries

* Fix translation (leave it)

leave: zostaw -> opuść

* Ldap merge users (RocketChat#3992)

* Allow merge users from ldap

* Fix last commit, do not override userData in ldap sync

* Fix using cache in develop

* Fix message input flex model (RocketChat#3986)

@RocketChat/core

Closes RocketChat#3900

* Add online count in rooms member list

* Add error handling for stat server request

* Add bot-helpers package (RocketChat#3799)

* Add bot-helpers package

Hubots can query user collections through provided methods

* Update bot-helpers package

Fixes codacy issues

* Disable bot-helpers package by default

* Add settings for botHelpers user fields access

* Refactor botHelpers to use setting, validate user

* Add errors when bot requests don’t have permission

* Move settings call outside class for method

* Remove status from bot helper setting, is implicit

* Remove bot helper setting logging

* Move geolocation function to outside template

* Change the message input buttons layout

* Show guest name as message alias

* Add font family configuration

* Change main fonts

* removed text shadows

* remove height calculation

* Load and clear some cache on login

* version bump to 0.37.0

* Fix eslint

* Fix admin option of type select

* Sllow deletion of records with same id

* added uyghur translation for rocketchat-lib

* added uyghur translation for rocketchat-lib

* Fixed Not showing upload button on safari

* Fix slackbridge import and slack importer ids conflict

* Make slackbridge-import import from begin to end;
Suppress message-pinned notification from import;
Fix bug in _id generation for importer;

* livechat office hours

* changed time check from every second to every minute

* style fixes

* Init Iframe integration

* more fixes

* Fix eslint issues

* fixes

* fixes

* more style changes

* more style changes

* more style changes

* checked for uyghur translation's syntax errors

* Fix livechat branding over options button

Closes RocketChat#4030

* LingoHub Update 🚀

Manual push by LingoHub User: Gabriel Engel.
Project: Rocket.Chat

Made with ❤️ by https://lingohub.com

* fix syntax

* LingoHub Update 🚀

Manual push by LingoHub User: Gabriel Engel.
Project: Rocket.Chat

Made with ❤️ by https://lingohub.com

* Improvements to pinned items

* added globals comment as recomended by sampaiodiego

* added comments to office hour model methods

* removed trailing spaces

* test why build fails part1

* add model back in for test

* fixed lint errors

* version bump to 0.37.1

* fixed filename typo

* handle locations when disabled

* update to depend only on the gMaps API key, add i18n strings

* Add global event `unread-changed-by-subscription`

* Formatting and adding some missing permissions to standard roles

* Added File Uploaded text on attachments to i18n

* Check timestamp before notifying users

* improved ts diff function

* Set message.ts if empty

* update moment locales

* Improvements/login and registration (RocketChat#4073)

* Remove uncessary log

* Refactor login/registration code

* New setting to add custom translations

* Add option to not require password confirmation on signup

* Add Custom Fields for registration

* Closes RocketChat#4036; Do nore remove roles when editing user data

* Add arrow to indicate fields of type select

* Improve lazy loading of custom fields and translations

* Fix multiple notifications (closes RocketChat#3517) (RocketChat#4074)

* Fix multiple notifications (resolve RocketChat#3517) and close after click

* Fix replacing notification for different messages from the same room

* Added option to populate Rocket Chat with LDAP users (import them) (RocketChat#4054)

* Added option to populate Rocket Chat with LDAP users (import them)

* fix syntax

* LingoHub Update 🚀

Manual push by LingoHub User: Gabriel Engel.
Project: Rocket.Chat

Made with ❤️ by https://lingohub.com

* Action links improvements

- Adds a default style to buttons
- Remove <meta> tag from message

* Make sure Sandstorm.notify is always called for DMs

* Try to work around bug with identity being saved/restored

* Fix the verbs in Sandstorm activity events

* Fix offering Sandstorm grains without a title

* Eslint fixes

* Tweak Sandstorm activity event text

* Fix mispelling for seriliazedDescriptor

* Updated loginform a11y and UX - labels instead of placeholders (RocketChat#4075)

* Use label for select fields in registration form

* Add the timer for disconnecting, one minute after going in the background it'll disconnect

* Open room correctly after creation and new messages

* Change push gateway and stats server address

* Set gitlabs scope to 'api', the only support scope.

Fixes RocketChat#3987

* Update to Autolinker.js 0.28.0

* Less borders (RocketChat#4101)

* Removing border-bottom

* Removing border-bottom

* remove shadow rom buttons

* move colours to the correct file

* removed side margins around buttons

* Changes rtl check in ChatMessages class (RocketChat#4049)

* Added view-d-room to guest role

So they can see direct messages.

* valueChanged optimization

valueChange checks if the text is rtl or ltr on every input, changed the method to check only the first input.

* Update startup.coffee

* Fixes pr RocketChat#4049

fixes the value.lenght to value.length and used the this.value instead of the value in the parameter

* Update chatMessages.coffee

* Update startup.coffee

* Update startup.coffee

* Improve stream broadcast connection (RocketChat#4119)

* Renaming files (RocketChat#4118)

* moving from coffee to js

* renaming method

* Add Ubuntu 16.04-under 30 seconds snap deployment

* Add Ubuntu App Explorer link for 30 second deploy

-  added official app explorer link + logo
-  fixed link from ToC
-  fixed XMPP bridge link

* createPrivateGroup method

* Standardized thrown errors

* Moved createPrivateGroup to rocketchat-lib

* Fixes RocketChat#4121 ModelsBase.update throws error when using array update operators

* fixed buttons margins and upload file list

* Fixing buttons margins

* Fixing buttons margins

* Slackbridge refactoring

* Add role to disable/enable channel preview (RocketChat#4127)

* Add role to disable/enable channel preview

* Add message to inform user

* Add room setting to require code to join Room (RocketChat#4126)

* Fix scoped permission verification when no scope passed

* Refactor room settings

* Add room setting to require code to join

* Initial work on getting the smarsh connector wired up. livechat package disabled for now, will enable it again (disabled for build speed)

* New and unique loading

* Fix loading of mizzao’s package

* Fix eslint errors

* Smarsh connector work/Message History.

This will send emails the configured email address with a table of all messages from all the different rooms, including direct messages.Each room will be a different email sent.
Files uploaded will be attached to the email IF and ONLY IF the uploads are to the database or the file system.

* Add the livechat packages back in

* LingoHub Update 🚀

Manual push by LingoHub User: Gabriel Engel.
Project: Rocket.Chat

Made with ❤️ by https://lingohub.com

* Fix the incorrectly spelled word and also defer the execution to be async, for the smarsh items

* The update of insertOrUpdate doesn't do anything with roles, no need to check there for last admin

* Change the wording of the embed description

* Refactoring

* Don't send offline emails to users who aren't active

* Fix user update check for last admin

* Reenabled user avatar

* Fix missing semicolong

* Do not check for last admin while updating a user

* version bump to 0.38.0

* Tweak SandstormOembed styling/format

Remove the "Click to open grain" text and make the title look like a
link.

* Parameter Checks  (RocketChat#4147)

* add checks in the methods for checking if the data received in the parameters are in their correct type

* Put the checks in the start of the method and fixed some indentation

* no message

* no message

* no message

* no message

* no message

* no message

* no message

* Fix input label position and background color for autofill fields

* Fix E-Mail address in reset password form is case-sensitive (RocketChat#4158)

* Slackbridge fixes (RocketChat#4162)

* Remove double error trhow

* Fix channel name changed

* Fix not sending notifications for old messages

* Add option to silence adding users to room

* Silence adding existing users to room

* Add try/catch in set avatar to prevent timeout issues

* Save topic message in correct date/time

* Add logs

* fix server/methods/sendForgotPasswordEmail.coffee:15:15: unmatched OUTDENT

* Disable unessary fields on push settings

* Fix resize of message box on mobile when paste and send using `return` on keyboard

* Add try/catch for avoiding log of error on duplicate messages

* Fix importing errors

* Hide messages from stream while importing with SlackBridge

* Fix settings not being saved if the value was a number or boolean.

* Add the missing file, converted the coffeescript file to javascript

* Do not force string as setting value

* Fix the generateEml throwing an error when the message type isn't defined and fix a conflict of the saveSetting.coffee being added back in when it was removed

* Update the opened livechat room by token

* Support jitsi message types in the smarsh connector

* Fix an exception occuring in the smarsh connector when a user didn't have an email, adds a setting to configure the default email for missing emails

* Make the smarsh time format more aligned with the example provided.

* Add image attachment support when a bot (ex using giffy) posts just an image

* Accept username from SAML response

Closes RocketChat#4177

* Fix login font issues

* Change 'go to message' button style

* UI improvements to login screen

* Add roles user to slackbridge imported users

* Oops fixed dumb error

* Enable debug of push lib when debug setting is true

* Adds Support for  phabricator oauth server.

* added commentary

* fix syntax

* Add function unarchiveRoom to package.js

* Add setting to disable LDAP fallback to default account system

* Fix error with CustomOAuth on startup

* version bump to 0.39.0

* HTML-escape user data when storing in Meteor Error

* HTML-escape username when storing in Meteor Errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants