Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

name/link of channel/room in email notifications doesn't work with subfolder #3902

Closed
peccu opened this issue Aug 3, 2016 · 4 comments
Closed

name/link of channel/room in email notifications doesn't work with subfolder #3902

peccu opened this issue Aug 3, 2016 · 4 comments
Labels
feat: email type: bug
Milestone
0.37.0

Comments

@peccu
Copy link
Contributor

peccu commented Aug 3, 2016

Your Rocket.Chat version: 0.36.0

PR #3814 is not work when ROOT_URL with subfolder.

My ROOT_URL is http://domain/subfolder.

notification mail link is like http://domain/subfolderdirect/name.

Is my ROOT_URL is wrong?
@MartinSchoeler MartinSchoeler added this to the Important milestone Aug 8, 2016
@engelgabriel
Copy link
Member

We must try to replace all calls to ROOT_URL with a specific method that makes sure the returned string ends with a /

@MartinSchoeler
Copy link
Contributor

Hey the issue is being worked on here #3946 we hope it solves your problem!

@sampaiodiego sampaiodiego mentioned this issue Aug 9, 2016
Merged
@peccu
Copy link
Contributor Author

peccu commented Aug 12, 2016

umm...
current develop branch(0762aea) still generates wrong url.
PR #3946 changes url from http://domain/subfolderdirect/name to http://domain/direct/name.

I think it should http://domain/subfolder/direct/name.

@peccu
Copy link
Contributor Author

peccu commented Aug 15, 2016 •
edited
Loading

This issue needs fixes like this PR.
#3981

@marceloschmidt marceloschmidt modified the milestones: Important, 0.37.0 Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat: email type: bug
Projects
None yet
Milestone
0.37.0
Development

No branches or pull requests
4 participants
@peccu @engelgabriel @marceloschmidt @MartinSchoeler