added name/link of channel/room in email notifications

[danielrohers]

@RocketChat/core

Closes E-Mail notifications: include name/link of channel/room #3704

Hello, add link to the channel that was mentioned...

[sampaiodiego]

thanks for the contribution @danielrohers

I don't like the idea of repating the subject on email body, specially because it adds the "server name" (which is already in the body header)..

I think we should change the translations for Offline_Mention_Email and Offline_DM_Email to not include the [__site__].. So we can use it in both places (subject and body) but adding the "server name" where it's needed. What you think?

[danielrohers]

I think it's a good idea @sampaiodiego

Is there any way to make this change with i18n files or I need to do manually?

I saw not treated the DM situation, I will adjust it too.

[sampaiodiego]

Is there any way to make this change with i18n files or I need to do manually?

@danielrohers have to do manually 😞 but a replace in all files should do the trick 😃

[danielrohers]

@sampaiodiego preview messages. Site_Name believe to be interesting in the subject to easily see the contexts...

[sampaiodiego]

cool @danielrohers

can you please rebase and fix the conflicts?

[rodrigok]

Hi @danielrohers, what do you think about adding a center (big and green?) button bellow all text with text "Go to channel" instead of that small link?

Another thing, can you remove that > on the top of the email?

[danielrohers]

Hi @rodrigok,

Great! I better keep the "RC blue" color and with "Go to message" since it can use in both cases (DM/Channel).

What do you think?

[rodrigok]

@danielrohers Ok, better, go ahead 😄

[danielrohers]

Hey guys

I made the changes, I believe that really got much better :)

@sampaiodiego @rodrigok

[rodrigok]

@danielrohers can you change this to use TAPi18n to GO TO MESSAGE and add this text to en.i18n.json?

[rodrigok]

Can you solve the conflicts too?

[rodrigok]

@danielrohers Awesome man :)