Color issues

[sampaiodiego]

Your Rocket.Chat version: 0.47.0-develop

After the merge of #4803 I've found many color issues, so I'll try to gather them all here.

• Missing borders on My Account page: image
• Date divider white: image
• Favorite icon without gray border: image
• Message text box without border: image
• white and transparent "unread bar": image
• Room's list hover too white: image
• Livechat menu has a lighter background: image
• "unread messages" bar at the very top disappears whenever the scroll event is triggered and completed (thanks @frdmn - post): image
• It used to have a line above the "unread messages" divider: image
• Code styles: image
• the background of what before was a grayish-white is now full-white: image
• Attachment buttons darker then before: image
• @all changed to red; @mention changed to a darker blue; darker role tag background: image
• Other's @mention changed to gray: image
• Message action buttons styles: image
• emoji picker search box background used to be white: image
• message editing highlight got red and the text field got white: image
• Expand/collapse button on admin are got white (gray only on hover): image
• File upload got a more transparent background and it's not perfectly aligned: image
• "user is typing" is breaking line if you're editing some message: image
• messages scrollbar got white: image
• Login form auto-fill sets a background on text fields (thanks @MartinSchoeler - post): image
• Background no changing on hovering attachment buttons: image
• Server connection status: image
• light blue buttons got white: image
• First lines of a multi-line message increases the size down: image

[frdmn]

Also @TheReal1604 told me that the loading spinners (pulsing dots) are gone, which I can confirm.

I guess that's related to that merge as well.

[frdmn]

And the "unread messages" bar at the very top disappears whenever the scroll event is triggered and completed:

[engelgabriel]

Initial fix via 82847da

[MartinSchoeler]

This happens if you use the auto complete in the login page

[timkinnane]

Thanks @sampaiodiego for finding all those issues. I knew about some of them, but thought the effort to get a more consistent baseline was a net improvement, even with some bugs. My PR had to survive merges with multiple versions too, so I think some of those issues are the result of conflicts being resolved without noticing all the details they impact. Hopefully I'll get some time to help resolve the remaining ones.

[karlprieb]

@timkinnane if you get some time call me on Rocket.Chat :) I'm fixing these errors.

[timkinnane]

@karlprieb nice work, thanks. I find it hard to match up with you guys time zone for calls outside work hours, but will try and catch you online in demo.rc.
My main concern is just that the color scheme variables are used to resolve any issues. Not worried if the colors themselves need changing or we use one instead of another. Just wanted to avoid any hard coded colors in the less files, to achieve the main objective of letting people set their own color scheme without having fixed colors they can't change ruining the application of their scheme.

[Sing-Li]

More unintended CSS changes due to the PR continues to pour in.

Not all impact has been addressed. Re-opening this case.

[karlprieb]

I will look these changes.

[IQ2022]

Unread messages stays longer than it should, also it has wrong place it overlays the username, so if you want to change or react to a msg, it wont allow you to click on the setting wheel..

[engelgabriel]

[engelgabriel]

@IQ2022 can you open a new issue for the "Unread messages stays longer than it should, also it has wrong place it overlays the username"?