Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new setting for GitLab server URL #557

Closed
Sing-Li opened this issue Aug 23, 2015 · 7 comments
Closed

Create a new setting for GitLab server URL #557

Sing-Li opened this issue Aug 23, 2015 · 7 comments
Milestone

Comments

@Sing-Li
Copy link
Member

Sing-Li commented Aug 23, 2015

Please see #512

A new setting needs to be created to configure the gitlab server URL.

See packages/gitlab/gitlab_common.js

@engelgabriel engelgabriel added this to the GitLab 0.8 milestone Aug 23, 2015
@dosire
Copy link

dosire commented Aug 23, 2015

/cc @maxlazio

@engelgabriel engelgabriel modified the milestone: GitLab 0.8 Aug 23, 2015
@marceloschmidt
Copy link
Member

@Sing-Li, I believe packages/gitlab is under our control, right? So that it would be possible for us to add a gitlab_startup + tapi18n files? I'm working on adding a settings option and I would like it to be set up under this package files... I'm curious as to why it wasn't named rocketchat-gitlab, if it's ours, hence the doubt.

@Sing-Li
Copy link
Member Author

Sing-Li commented Aug 24, 2015

@marceloschmidt ... Thanks, the thought is to contribute it via Atmosphere so any meteor app can oauth via GitLab servers. I think we can still add anything we like to it as long as it doesn't break things for non Rocket.Chat users.

@marceloschmidt
Copy link
Member

I see... but then adding the URL as a RocketChat.settings.get('API_Gitlab_URL') would not be good, because non-Rocket.Chat users would not be able to set the URL?

@Sing-Li
Copy link
Member Author

Sing-Li commented Aug 24, 2015

They have to set it, somehow :-) Open for ingenious implementations.

@marceloschmidt
Copy link
Member

@Sing-Li I have added rocketchat-gitlab package, which creates the API_Gitlab_URL and overwrites Gitlab.Server with defined value in that setting. The package also loads the language files required for displaying the translated labels in settings page. Check out #563

@Sing-Li
Copy link
Member Author

Sing-Li commented Aug 24, 2015

@marceloschmidt 👍 You da man!

@engelgabriel engelgabriel modified the milestones: 0.40.0, GitLab Jan 24, 2017
HappyTobi pushed a commit to HappyTobi/Rocket.Chat that referenced this issue Jul 10, 2018
* Update app.html

* Update start.js

* Update servers.js
HappyTobi pushed a commit to HappyTobi/Rocket.Chat that referenced this issue Jul 10, 2018
* Update app.html

* Update start.js

* Update servers.js
Peym4n pushed a commit to redlink-gmbh/Rocket.Chat that referenced this issue Apr 4, 2019
Shailesh351 pushed a commit to Shailesh351/Rocket.Chat that referenced this issue Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants