Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve alerts of password reset #70

Closed
engelgabriel opened this issue May 31, 2015 · 6 comments
Closed

Improve alerts of password reset #70

engelgabriel opened this issue May 31, 2015 · 6 comments

Comments

@engelgabriel
Copy link
Member

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@alayek
Copy link
Contributor

alayek commented Jan 13, 2016

hi, I am interested in working on this issue. Though I am new, I have already worked on #1725 and have gotten some familiarity with the process.

@Sing-Li
Copy link
Member

Sing-Li commented Jan 14, 2016

@alayek you're on! Looking forward to the PR.

@alayek
Copy link
Contributor

alayek commented Jan 14, 2016

Before that @Sing-Li, I would like to get some clarity on the issue, since this is lacking description in detail.

For the moment, we are resetting password by going to My Account -> Profile and then hitting Save Changes. This displays a Toast notification saying Profile Saved Successfully

Are we planning to replace this Toast, with some password change specific code? Like Password Reset Successfully ? Or would we want more, such as on reset password logout the user and ask the user to login again? Or do we add an email confirmation, with text like Someone just reset the password and a recovery link?

@MartinSchoeler
Copy link
Contributor

@engelgabriel which ones you mean? The toasts in the password reset by email and by settings looks pretty decent to me
workspace 1_013
workspace 1_014
Or maybe something i didn't see?

@eb-h
Copy link

eb-h commented Oct 17, 2017

Hi, I'd like to try to work on this issue as part of hacktoberfest but I'm not really sure what the issue is meant to address. The above comments indicate to me that there might not be that much left to do.

@dhruvdutt
Copy link

I would like to take this up. ✋

@theorenck theorenck removed this from the Mid-term milestone Dec 12, 2018
bhardwajaditya pushed a commit to bhardwajaditya/Rocket.Chat that referenced this issue Aug 21, 2019
* Initial commit for newsfeed

* Create server setting for Newsfeed

* Solve linting

* Callback for initializing and deinitializing newsfeed

* Solve liniting

* Access all users in initialize function

* Check if newsfeed for a user already exists

* Partial progress upload
Declaring Newsfeed URL
Declaring Newsfeed as new roomType
Displaying the correct Newsfeed for the owner

* Add deinitialize newsfeed function

* set newsfeed_enabled default as false

* Delete createNewsfeed.js

* Delete createNewsfeed.graphqls

* Delete newsfeed.graphql

* Delete no-use file created by me

* Display newsfeed channel name as Newsfeed in UI

* Create Newsfeed when a new user registers on the server

* Newsfeed creation using username instead of name

* Few Improvement:
-Change newsfeed icon to star
-change channel type to n in canSendMessage function

* Initial commit for follow user and follow button

* Initialize follow user method

* Follow Meteor method initialized

* Follwers and following update in database and creation of toastr

* solve linting

* Change follow button to unfollow if already followed

* Create unfollow user method

* Update followUser method to store followers as object with _id as the key

* Update hasAlreadyFollowed method in respond to change in storage scheme

* Update unfollowUser to new scheme

* Add to deInitialize newsfeed to remove following and followers from database

* based newsfeed type room on private group

* Mid progress for displaying messages in newsfeed

* Publish followers and following from server to client

* Relaying of first messge successful

* Relay of first message

* Solve linting

* partial improvements

* Revert "Solve linting"

This reverts commit 14d4a73.

* Revert "partial improvements"

This reverts commit 1bcc673.

* Solve linting

* Partial progress with bug and without lint

* Relay with identified bug

* getLastMessage method added

* Add getFollowers and getFollowing method

* Display of original channel name in newsfeed

* Revert "Display of original channel name in newsfeed"

This reverts commit b94ae9c.

* Add posted_in in front of sender in newsfeed

* Change isSequential for newsfeed

* Update followUser method to new schema

* Update hasAlreadyFollowed for new schema

* Update unfollowUser method to new schema

* Update getFollowers to new schema

* Update getFollowing and getFollowers

* removed test code

* Mid progress to new schema

* remove default user fields in accordance with new schema

* Migrate ChatMessage UI to new schema

* Only rooms which can be viewed by user can show messages in newsfeed

* Partial progress

* Crude time and channel based summarization system for newsfeed

* Eslint fix

* seperation of summarization

* Referesh in follow/unfollow button state

* summarization on client for newsfeed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests