Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of channel breaks links/references #7108

Open
mld18 opened this issue May 27, 2017 · 6 comments · May be fixed by #13269
Open

Renaming of channel breaks links/references #7108

mld18 opened this issue May 27, 2017 · 6 comments · May be fixed by #13269

Comments

@mld18
Copy link

mld18 commented May 27, 2017

Rocket.Chat Version: 0.55.1
Running Instances: 1
DB Replicaset OpLog: Disabled
Node Version: v4.2.6

When channels are renamed the links/references that point to the channel stop working. Moreover, the link labels keep the previous channel name.

E.g., suppose there is a channel #testchannel. In another channel a user wrote "Hey, see discussion in #testchannel". Now, we rename the channel to #a-testchannel. The message text remains as it used to be before the renaming action. Clicking on the #testchannel link in the message now yields an error message:
image

My expectations:

  1. The link in the message is still working (in Mongo DB the message even contains the technical key to the channel!)
  2. The message texts are always changed accordingly (=> "Hey, see discussion in #a-testchannel"). Perhaps, the changing user may choose whether the labels of channel references are supposed to be updated or not.

To me, this feels like a bug as it makes renaming a no-go.
This feature is important to us. We have a vast number of channels and seek for a way to flag certain channels. Way to go seems to be suffixes in the channel names. (I'll file a separate feature request for this.)

@localguru
Copy link
Contributor

Is the idea behind suffixes organizing channels in categories? See RocketChat/feature-requests#637.

@mld18
Copy link
Author

mld18 commented May 29, 2017

@localguru: That's right. However, I've opened RocketChat/feature-requests#109 for this. I'll link the two issues. Thanks for the hint!

From my perspective this issue remains a bug (renaming doesn't work as expected).

@localguru
Copy link
Contributor

@mld18 Markus, I'd love to see that feature too.

@mld18
Copy link
Author

mld18 commented Sep 5, 2017

A quarter of a year and a couple of Rocket releases have gone by and I wanted to check if there's any news on this bug here?
It's still a real impediment for us. I'm a little surprised that I see lots of new features in the release notes but it seems to me that this core functionality issue has remained untouched for quite a long time.

@Micha0203
Copy link

And almost one year later still no reply to this?
I just checked if this Bug is solved but we still have the same issue.

Any Plans on fixing this anytime??

@Kailash0311
Copy link
Contributor

I have fixed the issue but I am not able to change the unit tests accordingly.
Help appreciated. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants