Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sandstorm] Uploads are improperly linked #910

Closed
pjamar opened this issue Sep 26, 2015 · 6 comments
Closed

[Sandstorm] Uploads are improperly linked #910

pjamar opened this issue Sep 26, 2015 · 6 comments

Comments

@pjamar
Copy link

pjamar commented Sep 26, 2015

After uploading an image the resultant link in the chatroom wouldn't point to the proper place.

Steps to reproduce:

  1. Install Sandstorm instance
  2. Open general chat channel
  3. Push the clip icon and select and image to upload
  4. Upload
  5. Once finished a link to localhost will appear "http://127.0.0.1:8000/ufs/rocketchat_uploads/DNcsdWrAXzCPutzpx.jpg"

Expected:
Find a link that works. In my specific case I could see the image by using two URIs:

  • my_grain_uri/ufs/rocketchat_uploads/DNcsdWrAXzCPutzpx.jpg although with Sandstorm.io frame on it (not suitable for download)
  • long_id.myhostname.com/ufs/rocketchat_uploads/DNcsdWrAXzCPutzpx.jpg
@Sing-Li
Copy link
Member

Sing-Li commented Sep 26, 2015

Thanks for the detailed report! @pjamar

@Sing-Li
Copy link
Member

Sing-Li commented Nov 4, 2015

This should be fixed in the current base code. Need to verify after the next cut.

@engelgabriel
Copy link
Member

Can anyone test the version from https://s3.amazonaws.com/rocketchatbuild/rocket.chat.latest.spk and let me know if it is fixed?

@Jan02
Copy link

Jan02 commented Nov 27, 2015

@engelgabriel it stalls when creating a new grain

@engelgabriel
Copy link
Member

Thanks @Jan02 I noticed it yesterday :( #1496

@Sing-Li
Copy link
Member

Sing-Li commented Dec 15, 2015

Verified fixed on v0.9.0 by several users. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants