Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting message with store last message not removing #9332

Closed
geekgonecrazy opened this issue Jan 4, 2018 · 7 comments · Fixed by #9335
Closed

Deleting message with store last message not removing #9332

geekgonecrazy opened this issue Jan 4, 2018 · 7 comments · Fixed by #9335

Comments

@geekgonecrazy
Copy link
Contributor

Description:

If you have store last message turned on and then delete last message... that message still is on the channel.

Server Setup Information:

  • Version of Rocket.Chat Server: 0.60.3

Steps to Reproduce:

  1. Turn on Store Last Message
  2. Send a message
  3. Delete that message

Expected behavior:

Remove. Or show something like message deleted or something

Actual behavior:

Message stays

@geekgonecrazy
Copy link
Contributor Author

I assume the same happens if you edit the message as well

@sampaiodiego
Copy link
Member

this should have been fixed by #9227 I'll check what happened

@geekgonecrazy
Copy link
Contributor Author

ah didn't even see: #9202 😊

@soundstorm
Copy link
Contributor

@geekgonecrazy @sampaiodiego but can we add a function that iterates through all channels when toggling the option on and stores the last message? If you turn that feature on, it will show "No messages yet" even if there are messages in the channel (although I deactivated the feature again as we have too many channels).

@sampaiodiego
Copy link
Member

you need to enable Show Deleted Status to reproduce the error

@sampaiodiego
Copy link
Member

@soundstorm I thought doing that whenever you turn the feature on, but it would be too heavy on server.

@geekgonecrazy
Copy link
Contributor Author

geekgonecrazy commented Jan 4, 2018

@soundstorm I think that would be extremely heavy. Look at open.rocket.chat for instance. We have a looooooooooooooooooooooot of channels :)

[edit] yeah what he said 🔝 😁

@rodrigok rodrigok added this to the 0.60.4 milestone Jan 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants