Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More consistent HTML notifications and sounds #1116

Merged
merged 5 commits into from
Oct 23, 2015
Merged

More consistent HTML notifications and sounds #1116

merged 5 commits into from
Oct 23, 2015

Commits on Oct 15, 2015

  1. Notifications are more consistent (#1068). 

    - HTML notifications are shown when the user has selected the room of the message but the chat window does not have the focus.
- HTML notification and new message sound use the same condition.
- The unread count is always updated if the chat window does not have the focus.
    @teetrinkers
    teetrinkers committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    48f6e32 View commit details
    Browse the repository at this point in the history

  2. For @ALL, send notifications to all room users.

    @teetrinkers
    teetrinkers committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    b9a0691 View commit details
    Browse the repository at this point in the history

  3. Use RocketChat.models.Users.

    @teetrinkers
    teetrinkers committed Oct 15, 2015
    Configuration menu
    Copy the full SHA
    4531759 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2015

  1. Removed unused query variable.

    @teetrinkers
    teetrinkers committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    66870bc View commit details
    Browse the repository at this point in the history

  2. For @ALL send push notifications to online and offline users.

    @teetrinkers
    teetrinkers committed Oct 23, 2015
    Configuration menu
    Copy the full SHA
    7f0cc3e View commit details
    Browse the repository at this point in the history