Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Improve settings startup #15597

Closed
wants to merge 1 commit into from
Closed

[WIP] Improve settings startup #15597

wants to merge 1 commit into from

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 16, 2019 •
edited
Loading

  • Do not update settings that didnt change
  • Do not update if when have changed the commit base
  • Do not update if another process already updated the settings

@ggazzo ggazzo added this to the 2.3.0 milestone Oct 16, 2019
@lgtm-com
Copy link

lgtm-com bot commented Oct 16, 2019

This pull request introduces 2 alerts when merging 3422659 into a6080f7 - view on LGTM.com

new alerts:

  • 2 for Superfluous trailing arguments

@engelgabriel engelgabriel modified the milestones: 2.3.0, 3.1.0 Mar 17, 2020
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@engelgabriel engelgabriel modified the milestones: 3.1.0, 3.2.0 Apr 20, 2020
@sampaiodiego sampaiodiego marked this pull request as draft May 5, 2020 12:08
@sampaiodiego
Copy link
Member

are you willing to finish this?

@rodrigok
Copy link
Member

rodrigok commented May 7, 2020

Closed in favor of #17160

@rodrigok rodrigok closed this May 7, 2020
@rodrigok rodrigok deleted the improve/settings-startup branch May 7, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ggazzo @CLAassistant @sampaiodiego @rodrigok @engelgabriel