Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Correctly aligned input element of custom user status component #16151

Merged
merged 3 commits into from
Feb 20, 2020
Merged

Fix: Correctly aligned input element of custom user status component #16151

merged 3 commits into from
Feb 20, 2020

Conversation

ashwaniYDV
Copy link
Contributor

@ashwaniYDV ashwaniYDV commented Jan 7, 2020 •
edited
Loading

Closes #16145

Description:

Used default value of margin used in different components to keep UI consistent.

Before fix:

imageedit_4_3261222051

After fix:

aaaa
bbb

@ashwaniYDV
Copy link
Contributor Author

@sampaiodiego I have fixed the stylelint issue.

gabriellsh
gabriellsh requested changes Jan 7, 2020
View reviewed changes
Copy link
Member

@gabriellsh gabriellsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to create a new file or change anything, simply add <div class="rc-input__wrapper"> around the select element. (The wrapper applies the margins automatically). Also thanks for your constant contribution to the project! ;)

@ashwaniYDV
Copy link
Contributor Author

@gabriellsh I have made the requested changes.
Thank you 😇

@ggazzo ggazzo changed the title [UI] Correctly alligned input element of custom user status component [FIX] Correctly aligned input element of custom user status component Feb 20, 2020
@ggazzo ggazzo merged commit 13dc9aa into RocketChat:develop Feb 20, 2020
@rodrigok rodrigok changed the title [FIX] Correctly aligned input element of custom user status component Fix: Correctly aligned input element of custom user status component Mar 26, 2020
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input element of "user-status-custom" component is not alligned correctly.
3 participants
@ashwaniYDV @gabriellsh @ggazzo