Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Added autofocus to Directory #16217

Merged
merged 2 commits into from
Feb 20, 2020
Merged

[IMPROVE] Added autofocus to Directory #16217

merged 2 commits into from
Feb 20, 2020

Conversation

ashwaniYDV
Copy link
Contributor

@ashwaniYDV ashwaniYDV commented Jan 11, 2020 •
edited
Loading

Closes #16216

Description:

Focus should be on search box of directory component, when user clicks on Directory button.

focus

@ashwaniYDV
Copy link
Contributor Author

@mariaeduardacunha Would you please review

@ggazzo ggazzo added this to the 3.0.0 milestone Jan 31, 2020
@ggazzo ggazzo requested a review from dudizilla January 31, 2020 01:41
@ggazzo ggazzo added the ui/ux label Jan 31, 2020
@ggazzo ggazzo changed the title Added autofocus to Directory [IMPROVE] Added autofocus to Directory Feb 20, 2020
@ggazzo ggazzo merged commit 4fa663d into RocketChat:develop Feb 20, 2020
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Merged
@ankar84
Copy link

ankar84 commented Apr 16, 2020

@ashwaniYDV that do not work in 3.1.1
search_bug1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudizilla dudizilla dudizilla approved these changes

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees
No one assigned
Labels
ui/ux
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

[IMPROVEMENT] Focus is not on search box of directory component, when user clicks on Directory button
5 participants
@ashwaniYDV @ankar84 @gabriellsh @dudizilla @ggazzo