Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Omnichannel notification on new conversations displaying incorrect information #16346

Merged
merged 3 commits into from
Mar 28, 2020

Conversation

renatobecker
Copy link
Contributor

Closes #16165

The Omnichannel notification is not working properly when a new conversation starts.
It happens when running the Manual Selection routing method, there was a translation string missing, as well as the notification payload, that was using information no longer available.

@renatobecker renatobecker added this to the 3.0.0 milestone Jan 27, 2020
@renatobecker renatobecker changed the title [FIX] Omnichannel notification on new conversations [FIX] Omnichannel notifications on new conversations Jan 27, 2020
@renatobecker renatobecker changed the title [FIX] Omnichannel notifications on new conversations [FIX] Omnichannel notification on new conversations displaying incorrect information Jan 28, 2020
@renatobecker renatobecker modified the milestones: 3.0.0, 3.1.0 Feb 27, 2020
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@rodrigok rodrigok changed the title [FIX] Omnichannel notification on new conversations displaying incorrect information Regression Omnichannel notification on new conversations displaying incorrect information Mar 28, 2020
@rodrigok rodrigok changed the title Regression Omnichannel notification on new conversations displaying incorrect information Regression: Omnichannel notification on new conversations displaying incorrect information Mar 28, 2020
@rodrigok rodrigok merged commit f925e44 into develop Mar 28, 2020
@rodrigok rodrigok deleted the fix-omnichannel-desktop-notification-on-new-rooms branch March 28, 2020 19:56
ggazzo added a commit that referenced this pull request Mar 30, 2020
…to feat/directory

* 'feat/directory' of github.com:RocketChat/Rocket.Chat:
  Add bio as default field for searching
  Remove topic column from users tab
  Featured on top always
  [NEW] Home button on sidebar (#17052)
  [IMPROVE] Repeat “Reply In Thread” and “Add Reaction” inside the message actions menu (#17073)
  Make DirectMessageRoomType.isGroupChat() accept null roomData (#17074)
  [IMPROVE] Tab Bar actions reorder (#17072)
  Regression: Overwrite model functions on EE only when license applied (#17061)
  Regression: users.setStatus throwing an error if message is empty (#17036)
  Regression: Omnichannel notification on new conversations displaying incorrect information (#16346)
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LiveChat push notification showing undefined
3 participants