Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setting Accounts_LoginExpiration #1652

Merged
merged 1 commit into from
Dec 14, 2015
Merged

Added setting Accounts_LoginExpiration #1652

merged 1 commit into from
Dec 14, 2015

Conversation

kristjankullerkann
Copy link
Contributor

Setting allows admin to modify Meteor.loginTokenExpires from default 90 days to something else.
Server restart is required for this setting to take effect.
Default value is still 90 days if not modified by admin.

Setting allows admin to modify Meteor.loginTokenExpires from default 90 days to something else.
Server restart is required for this setting to take effect.
Default value is still 90 days if not modified by admin.
@kristjankullerkann
Copy link
Contributor Author

Sad side of this feature is that is dosn't matter if the browser is running or not when token expires - it will not be extended. This looks like a feature of meteor.
So if we would like to extend token when the user is logged in then there should be modifications on meteor side for this to work unless i'm mistaken.

engelgabriel added a commit that referenced this pull request Dec 14, 2015
This is a good start. LIke noted by @litewhatever there are limitations that related to the way meteor works. I can see some workarounds we could do, but that would need to be discussed and maybe submitted back to MDG.
@engelgabriel engelgabriel merged commit e287273 into RocketChat:develop Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants