Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Invite links counting users already joined #16591

Merged
merged 3 commits into from
Mar 11, 2020
Merged

[FIX] Invite links counting users already joined #16591

merged 3 commits into from
Mar 11, 2020

Conversation

ritwizsinha
Copy link
Contributor

Closes #16573
out

@ritwizsinha
Copy link
Contributor Author

@gabriellsh please review

@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@sampaiodiego sampaiodiego changed the title Count only new users using invite link [FIX] Invite links counting users already joined Mar 11, 2020
@sampaiodiego sampaiodiego merged commit 5053dc4 into RocketChat:develop Mar 11, 2020
gabriellsh added a commit that referenced this pull request Mar 13, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
f702691 
…exact_search

* 'develop' of github.com:RocketChat/Rocket.Chat: (178 commits)
  [IMPROVE] Add option to require authentication on user's shield endpoint (#16845)
  [FIX] Custom OAuth Bug (#16811)
  [FIX] Integrations page pagination (#16838)
  fix: livechat/facebook missing visitor data after registerGuest (#16810)
  [FIX] Invite links counting users already joined (#16591)
  [FIX] No settings to be displayed if search not found (#16255)
  [FIX] Removed some hardcoded texts (#16304)
  [FIX] Cannot unfollow message from thread's panel (#16560)
  Add Enterprise Edition license (#16801)
  [FIX] Fallback content-type as application/octet-stream for FileSystem uploads (#16776)
  [IMPROVE] Apps-engine E2E tests (#16781)
  [FIX] Remove spaces from i18n placeholders to show Personal access token (#16724)
  [NEW] SAML config to allow clock drift (#16751)
  [FIX] Slash command preview: Wrong item being selected, Horizontal scroll (#16750)
  [FIX] Cannot pin on direct messages (#16759)
  [FIX] Get all channels from Slack via REST API (#16767)
  LingoHub Update 🚀 (#16837)
  [FIX]  Flextab information is not working when clicking on visitor or agent username in Omnichannel messages (#16797)
  Update Node to 12.16.1
  [NEW] Update Meteor to 1.9.2 (#16718)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Merged
@engelgabriel engelgabriel added this to the 3.1.0 milestone May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

Invite links uses count even if the user is already in the room.
5 participants
@ritwizsinha @CLAassistant @gabriellsh @engelgabriel @sampaiodiego