Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Clear unread red line when the ESC key is pressed #16668

Merged
merged 1 commit into from
Feb 20, 2020
Merged

[FIX] Clear unread red line when the ESC key is pressed #16668

merged 1 commit into from
Feb 20, 2020

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Feb 20, 2020

Closes #16635

@ggazzo ggazzo added the ui/ux label Feb 20, 2020
@ggazzo ggazzo added this to the 3.0.2 milestone Feb 20, 2020
@sampaiodiego sampaiodiego changed the title [FIX] Clear unread red line if the ESC was pressed [FIX] Clear unread red line when the ESC key is pressed Feb 20, 2020
@sampaiodiego sampaiodiego merged commit 9bd8722 into develop Feb 20, 2020
@sampaiodiego sampaiodiego deleted the fix/unread-again branch February 20, 2020 17:39
sampaiodiego pushed a commit that referenced this pull request Feb 20, 2020
@ggazzo @sampaiodiego
[FIX] Clear unread red line when the ESC key is pressed (#16668)
92f0054
@sampaiodiego sampaiodiego mentioned this pull request Feb 20, 2020
Merged
sampaiodiego pushed a commit that referenced this pull request Feb 21, 2020
@ggazzo @sampaiodiego
[FIX] Clear unread red line when the ESC key is pressed (#16668)
6164f76
gabriellsh added a commit that referenced this pull request Feb 21, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
256f5d3 
…use_scrollableArea

* 'develop' of github.com:RocketChat/Rocket.Chat: (30 commits)
  [FIX] ie11 support (#16682)
  Regression: Show upload errors (#16681)
  [FIX] Delete messages while searching bug (#16568)
  Use insertSync
  [FIX] Image uploads (thumbnails) out of threads are not visible in regular message view (#16416)
  [FIX] Added an option to pin/unpin a thread message by admin (#16457)
  [CHORE] Look for Storybook stories on `app/` too (#16595)
  [IMPROVE] Removed the 'reply in thread' from thread replies (#16630)
  [FIX] Changed Opt_In message (#16631)
  [FIX] LDAP sync admin action was not syncing exisent users (#16671)
  [IMPROVE] Check agent status when starting a new conversation with an agent assigned (#16618)
  [FIX] Additional scroll when contextual bar is open (#16667)
  [FIX] Clear unread red line when the ESC key is pressed (#16668)
  [FIX] users.info endpoint not handling the error if the user does not exist (#16495)
  [NEW] Save default filters in the Omnichannel Current Chats list (#16653)
  Update app/utils/client/lib/RestApiClient.js
  Update app/utils/client/lib/RestApiClient.js
  send files over rest api
  [BUG][FIX] If InternalHubot_Username is undefined then rocket.cat should be default bot
  Improved isSingular function
  ...
gabriellsh added a commit to subham103/Rocket.Chat that referenced this pull request Feb 21, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into pr/1…
d03f908 
…6680-subham103-fixMessageCountStatistics

* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits)
  [FIX] ie11 support (RocketChat#16682)
  Regression: Show upload errors (RocketChat#16681)
  [FIX] Delete messages while searching bug (RocketChat#16568)
  Use insertSync
  [FIX] Image uploads (thumbnails) out of threads are not visible in regular message view (RocketChat#16416)
  [FIX] Added an option to pin/unpin a thread message by admin (RocketChat#16457)
  [CHORE] Look for Storybook stories on `app/` too (RocketChat#16595)
  [IMPROVE] Removed the 'reply in thread' from thread replies (RocketChat#16630)
  [FIX] Changed Opt_In message (RocketChat#16631)
  [FIX] LDAP sync admin action was not syncing exisent users (RocketChat#16671)
  [IMPROVE] Check agent status when starting a new conversation with an agent assigned (RocketChat#16618)
  [FIX] Additional scroll when contextual bar is open (RocketChat#16667)
  [FIX] Clear unread red line when the ESC key is pressed (RocketChat#16668)
  [FIX] users.info endpoint not handling the error if the user does not exist (RocketChat#16495)
  Update app/utils/client/lib/RestApiClient.js
  Update app/utils/client/lib/RestApiClient.js
  send files over rest api
  [BUG][FIX] If InternalHubot_Username is undefined then rocket.cat should be default bot
  Improved isSingular function
  Add message_pruned and file_pruned for singular file or message deleted
  ...
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees
No one assigned
Labels
ui/ux
Projects
None yet
Milestone
3.0.2
Development

Successfully merging this pull request may close these issues.

Unread messages red line lingers, esc key won't clear it
2 participants
@ggazzo @sampaiodiego