-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Settings to enable E2E encryption for Private and Direct Rooms by default #16928
Conversation
This pull request introduces 2 alerts when merging 88ad339 into 4a14f44 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you think GENERAL
should be created using createRoom
as well?
Rocket.Chat/server/startup/initialData.js
Line 15 in a102c6f
Rooms.createWithIdTypeAndName('GENERAL', 'c', 'general', { |
app/e2e/server/beforeCreateRoom.js
Outdated
import { settings } from '../../settings'; | ||
|
||
callbacks.add('beforeCreateRoom', ({ type, extraData }) => { | ||
if (['d', 'p'].includes(type)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test is kinda happening two times.. I think leaving only the if
below makes more sense.
Co-Authored-By: Diego Sampaio <[email protected]>
Co-Authored-By: Diego Sampaio <[email protected]>
Co-Authored-By: Diego Sampaio <[email protected]>
…by-default # Conflicts: # app/meteor-accounts-saml/server/saml_server.js
This pull request introduces 2 alerts when merging edacf1a into 292a7c3 - view on LGTM.com new alerts:
|
Why this was merged when: a) It is still considered Beta b) It is still not supported on any of the mobile apps? I just don't get the logic of enforcing this by default when the code is not considered stable, and the apps have no support. Also noted that these probably still apply (for those who do not read documentation)
|
@reetp this is not enabled by default, but a setting to be able to enable it by default. There are some clients that want this feature since it doesn't hurt anyone we added the option. Yes, it's still in beta, it's not supported by our mobile apps yet, but if you need this and use only the web clients you may use this new setting. |
KK - sorry but the heading was not very clear.
Indeed
Yup. Thanks for the clarification. |
No description provided.