Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] [ENTERPRISE] Engagement Dashboard #16960

Merged
merged 39 commits into from
Mar 24, 2020
Merged

[NEW] [ENTERPRISE] Engagement Dashboard #16960

merged 39 commits into from
Mar 24, 2020

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Mar 21, 2020 •
edited
Loading

It adds the Engagement Dashboard for the Enterprise Edition.

tassoevan and others added 30 commits March 20, 2020 23:34
@tassoevan
Add app module for engagement dashboard
f364952
@tassoevan
Add naive component prototype
1b9aab5
@tassoevan
Fix broken import
2dbfa67
@tassoevan
[NEW] Engagement Dashboard - Layout prototype (#91)
3d90358 
* Split tabs

* Move components under admin

* Add NumberIndicator

* Move components to /app/engagement-dashboard

* Update Fuselage components usage

* Fix layout issues in UsersTab

* Add prototype of MessagesTab

* Add ChannelsTab prototype

* Add LegendSymbol

* Refactor some symbols

* Add Growth component

* Add Counter component

* Add CountGraph component

* Update Tabs

* Split smaller graph components

* Add missing stories

* Move tabs

* Add CounterSet

* Add Section
@tassoevan
Fix color transitions in growth symbols
a036be5
@tassoevan
[NEW] Engagement Dashboard - Client routes (#102)
e06eaf7 
* Add Engagement Dashboard route

* Add admin sidebar entry

* Move mount/unmount handling to routes module

* Unmount component before FlowRouter's reactivity be triggered
@MarcosSpessatto @tassoevan
[NEW] Engagement Dashboard Backend (#98)
b91bc88 
* Add endpoint to retrieve messages week data

* Add endpoint to retrieve message quantity by room type

* Endpoint to retrieve top five popular channels

* Add room type validation

* Add endpoint to get list of channels and messages from current and last week

* fix lint

* fix lint

* New users metrics

* Add endpoint to get active users overview

* Add endpoint to get active users by month

* Endpoint to get busiest chats by period of 12 hours

* Endpoint to get busiest chats by day in a week

* endpoint to get the number of session by day in a week

* Fix aggregate to get active session by hour in a day

* Improve some code

* rename field
@tassoevan
Fix some layout issues
b68d4ec
@tassoevan
Add prototype of NewUsersSection
7b788b1
@tassoevan
Feed data to a graph
49a629e
@tassoevan
Add prototype of ActiveUsersSection
74eaed3
@tassoevan
Add prototype of UsersByTimeOfTheDaySection
439d313
@tassoevan
Embed heat map into UsersByTimeOfTheDaySection
8256853
@tassoevan
Fix import paths
ceb70ca
@tassoevan
Add prototype of BusiestChatTimesSection
11c7e8f
@tassoevan
Enhance NewUsersSection
22dd297
@tassoevan
Enhance ActiveUsersSection
ce76804
@tassoevan
Enhance UsersByTimeOfTheDaySection
c750428
@MarcosSpessatto @tassoevan
Rename some endpoints and change its response structures
454e6fc
@tassoevan
Update NewUsersSection
7367345
@MarcosSpessatto @tassoevan
Rename and improve endpoints
c8059e0
@tassoevan
Update endpoints
940df43
@tassoevan
Add more chart adjustments
3b86249
@tassoevan
Fix tabs position
74c1367
@tassoevan
Inject data into some sections
40f2835
@tassoevan
Fix some layout issues
578b456
@tassoevan
Remove unused components
c13d817
@tassoevan
Fix API route
13b10fa
@tassoevan
Add TableSection prototype
0c7aaf8
@tassoevan
Add pagination behavior
d5e8558
@rodrigok
Copy link
Member

rodrigok commented Mar 21, 2020 •
edited
Loading

Need to move the models to the ee folder It's better to keep the models outside unless they need to override existent methods.

rodrigok
rodrigok previously approved these changes Mar 21, 2020
View reviewed changes
rodrigok
rodrigok previously approved these changes Mar 21, 2020
View reviewed changes
ggazzo
ggazzo requested changes Mar 21, 2020
View reviewed changes
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this graph should have some more valuable information
image
I'm sure I have more than 25 channels, and I just see "Showing results 1 - 1 of 1"
image

@robbyoconnor
Copy link
Contributor

Ugh this would be useful for the those of us who don't use the EE version...

@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
c57bd5c 
…/engagement-dashboard

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Race conditions on/before login (#16989)
  Fix: StreamCast was not working correctly (#16983)
@ggazzo
added count channel page
1bc60bf
ggazzo
ggazzo requested changes Mar 24, 2020
View reviewed changes
Copy link
Member

@ggazzo ggazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the t(...) calls and use a properly keys :)

@ggazzo ggazzo marked this pull request as ready for review March 24, 2020 19:46
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
09c28bf 
…/engagement-dashboard

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [IMPROVE] Ability to change offline message button link on emails notifications (#16784)
@gabriellsh
Added missing translation keys
c920a04
@ggazzo ggazzo merged commit 80c69c0 into develop Mar 24, 2020
@ggazzo ggazzo deleted the feat/engagement-dashboard branch March 24, 2020 22:28
ggazzo added a commit that referenced this pull request Mar 25, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into dm/m…
abaf370 
…ultiple-users

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [Regression] Replace the Omnichannel queue model observe with Stream (#16999)
  [NEW] Engagement Dashboard (#16960)
  Fix StreamCast info (#16995)
  [IMPROVE] Ability to change offline message button link on emails notifications (#16784)
  [FIX] Race conditions on/before login (#16989)
  Fix: StreamCast was not working correctly (#16983)
@robbyoconnor
Copy link
Contributor

robbyoconnor commented Mar 25, 2020 via email

@rodrigok rodrigok changed the title [NEW] Engagement Dashboard [NEW] [ENTERPRISE] Engagement Dashboard Mar 26, 2020
@rodrigok
Copy link
Member

@robbyoconnor exactly, this is an enterprise feature, stay stunned on our blog post, we will explain about the merge of the enterprise repository here In the community soon.

@robbyoconnor
Copy link
Contributor

I really wish you didn't go this route 😢

@robbyoconnor
Copy link
Contributor

This is valuable to those of us using it in FOSS communities

@rodrigok
Copy link
Member

@robbyoconnor everything we put on the enterprise (EE) will be valuable for people using the community (CE) version. The difference is that now we made the enterprise open source as well and everyone will be able to follow what we have and propose to EE version.

I believe you all understand that Rocket.Chat is a company and needs to have revenue to continue increasing the features of the CE version, you will notice that our releases will have much more changes and improvements on CE version than EE, but the EE needs to have some important differentials to be saleable otherwise everyone will use the CE and the core development here will stop.

We will have a blog post explaining all this soon.

Thanks

@robbyoconnor
Copy link
Contributor

I'll move this discussion to the community server.

gabriellsh added a commit that referenced this pull request Mar 26, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
bdace87 
…/react-root

* 'develop' of github.com:RocketChat/Rocket.Chat: (76 commits)
  Regression: Fix issue with opening rooms (#17028)
  Group DM improvements
  [NEW] Sort channel directory listing by latest message (#16604)
  [FIX] Wrong message count statistics in Admin info page (#16680)
  Fix: 2FA DDP method not getting code on API call that doesn’t requires 2FA (#16998)
  [NEW] Direct message between multiple users (#16761)
  Bump version to 3.0.7
  Regression: Remove deprecated Omnichannel setting used to fetch the queue data through subscription  (#17017)
  Regression: Remove deprecated Omnichannel setting used to fetch the queue data through subscription  (#17017)
  Bump version to 3.0.6
  [Regression] Replace the Omnichannel queue model observe with Stream (#16999)
  [FIX]  Keeps the agent in the room after accepting a new Omnichannel request (#16787)
  [Regression] Replace the Omnichannel queue model observe with Stream (#16999)
  [NEW] Engagement Dashboard (#16960)
  Fix StreamCast info (#16995)
  [IMPROVE] Ability to change offline message button link on emails notifications (#16784)
  Bump version to 3.0.5
  [FIX] Race conditions on/before login (#16989)
  [FIX] Race conditions on/before login (#16989)
  Fix: StreamCast was not working correctly (#16983)
  ...
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

@rodrigok rodrigok rodrigok left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tassoevan @rodrigok @robbyoconnor @ggazzo @MarcosSpessatto @gabriellsh