Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NEW] Merge Sort List and View Mode menus and improve its UI/UX #17103

Merged
merged 5 commits into from
Apr 1, 2020
Merged

[NEW] Merge Sort List and View Mode menus and improve its UI/UX #17103

merged 5 commits into from
Apr 1, 2020

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 31, 2020 •
edited by rodrigok
Loading

image

@ggazzo ggazzo changed the title [NEW] - Sort List, View Mode and Group by revamp [NEW] Sort List, View Mode and Group by revamp Mar 31, 2020
@ggazzo ggazzo added the ui/ux label Mar 31, 2020
@lgtm-com
Copy link

lgtm-com bot commented Mar 31, 2020

This pull request introduces 1 alert when merging ac8883f into d47921a - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

tassoevan
tassoevan requested changes Mar 31, 2020
View reviewed changes
app/ui-sidenav/client/SortList.js Outdated Show resolved Hide resolved
@ggazzo ggazzo merged commit fd09822 into develop Apr 1, 2020
@ggazzo ggazzo deleted the feat/sort-side-bar branch April 1, 2020 00:32
ggazzo added a commit that referenced this pull request Apr 1, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into feat…
f360f96 
…/directory

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [NEW] Sort List, View Mode and Group by revamp (#17103)
  Regression: Files were been deleted when deleting users as last members of private rooms (#17111)
@rodrigok rodrigok changed the title [NEW] Sort List, View Mode and Group by revamp [NEW] Merge Sort List and View Mode menus and improve its UI/UX Apr 1, 2020
gabriellsh added a commit that referenced this pull request Apr 2, 2020
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into new/…
8b98d21 
…default-favorite-channels

* 'develop' of github.com:RocketChat/Rocket.Chat: (304 commits)
  [FIX] Omnichannel endpoint `inquiries.getOne` returning only queued inquiries (#17132)
  Fix design review (#17133)
  Regression: Direct message creation by REST (#17109)
  Regression: Can't login with 2FA over REST API when 2FA via Email is enabled (#17128)
  Regression: Fix engagement dashboard urls, fixing Flowrouter imports (#17127)
  Regression: IE11 Support (#17125)
  [FIX] Federation delete room event not being dispatched (#16861)
  [FIX] Federation Event ROOM_ADD_USER not being dispatched (#16878)
  New Troubleshoot section for disabling features (#17114)
  Regression: Wrong size of Directory search/sort icons and Sort Channels menu not showing on production build (#17118)
  [NEW] Discussions: Inherit the public status of parent channel (#17070)
  Regression: fix fuselage import, remove directory css (#17116)
  [IMPROVE] Apps Engine: Reduce some stream calls and remove a find user from the app's status changes (#17115)
  Regression: Remove old and closed Omnichannel inquiries (#17113)
  [FIX] Member's list only filtering users already on screen (#17110)
  Single codebase announcement (#17081)
  [NEW] Directory page refactored, new user's bio field (#17043)
  [NEW] Sort List, View Mode and Group by revamp (#17103)
  Regression: Files were been deleted when deleting users as last members of private rooms (#17111)
  Regression: Block users was not possible for 1:1 DMs (#17105)
  ...
ggazzo added a commit that referenced this pull request Apr 3, 2020
@ggazzo
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into wrap…
e27cdbf 
…per-call-meteor-methods-over-rest

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Regression: Can't login with 2FA over REST API when 2FA via Email is enabled (#17128)
  Regression: Fix engagement dashboard urls, fixing Flowrouter imports (#17127)
  Regression: IE11 Support (#17125)
  [FIX] Federation delete room event not being dispatched (#16861)
  [FIX] Federation Event ROOM_ADD_USER not being dispatched (#16878)
  New Troubleshoot section for disabling features (#17114)
  Regression: Wrong size of Directory search/sort icons and Sort Channels menu not showing on production build (#17118)
  [NEW] Discussions: Inherit the public status of parent channel (#17070)
  Regression: fix fuselage import, remove directory css (#17116)
  [IMPROVE] Apps Engine: Reduce some stream calls and remove a find user from the app's status changes (#17115)
  Regression: Remove old and closed Omnichannel inquiries (#17113)
  [FIX] Member's list only filtering users already on screen (#17110)
  Single codebase announcement (#17081)
  [NEW] Directory page refactored, new user's bio field (#17043)
  [NEW] Sort List, View Mode and Group by revamp (#17103)
  Regression: Files were been deleted when deleting users as last members of private rooms (#17111)
  Regression: Block users was not possible for 1:1 DMs (#17105)
  Regression: Collapsible elements didn't respect attachment parameter. (#16994)
  [FIX] Apps Engine notifyRoom sending notification to wrong users (#17093)
@sampaiodiego sampaiodiego mentioned this pull request Apr 9, 2020
Merged
@zdumitru
Copy link
Contributor

The icon "AZ with an arrow" doesn't reflect what the menu actually does. It needs a new icon.

@kaiiiiiiiii
Copy link
Contributor

And "Group Discussions" is still visible, even though discussions are disabled ... but like many times before, no one cared about my PR comment ...

@kaiiiiiiiii kaiiiiiiiii mentioned this pull request May 12, 2020
Closed
@ggazzo
Copy link
Member Author

ggazzo commented Jun 4, 2020

@kaiiiiiiiii sorry but I cant see your previous comment where is the comment? that one is the first... did you finished your "review"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tassoevan tassoevan tassoevan approved these changes

Assignees
No one assigned
Labels
ui/ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ggazzo @zdumitru @kaiiiiiiiii @tassoevan