[NEW] Setting to determine if the LDAP user active state should be synced #17645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrauns
reviewed
May 14, 2020
| @@ -10,4 +8,4 @@ callbacks.add('ldap.beforeSearchAll', (searchParams) => { | |||
| options.attributes.push('pwdAccountLockedTime'); | |||
There was a problem hiding this comment.
It should be considered that microsoft active directory uses User-Account-Control Attribute Flags https://ldapwiki.com/wiki/User-Account-Control%20Attribute to control locked out/disabled accounts
There was a problem hiding this comment.
Thanks @bbrauns but the code doesn't support AD yet, would you mind to contribute this improvement?
rodrigok
approved these changes
Jun 19, 2020
rodrigok
requested changes
Jun 19, 2020
rodrigok
approved these changes
Jun 19, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17561
This PR adds a setting to determine if users should be enabled/disabled based on the LDAP status. It also fixes an issue where enterprise code was not properly validating if a license was active and causing some ldap code to be run on the community edition.