Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Elements select & multiSelect not rendered correctly in the App Settings #19005

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Regression: Elements select & multiSelect not rendered correctly in the App Settings #19005

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d96c3a
Fix app select & multiSelect settings not rendered correctly
shiqimei Sep 23, 2020
aa1f25e
Merge branch 'develop' into apps/fix-app-settings
d-gubert Sep 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions client/admin/apps/AppSettings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ function AppSetting({ appSetting, onChange, value, ...props }) {
type,
i18nLabel,
i18nDescription,
values,
} = appSetting;

const label = (i18nLabel && tApp(i18nLabel)) || (id || tApp(id));
Expand All @@ -58,6 +59,7 @@ function AppSetting({ appSetting, onChange, value, ...props }) {
value={value}
onChangeValue={onChange}
_id={id}
values={values}
{...props}
/>;
}