Show confirmation before leaving room #2113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unread message counter overlapped the "leave room" button, but if a user clicked on the counter, the "leave room" button was still active, causing users to accidentially leave the room. Prevent this by hiding the leave buttons if unread messages are shown.
brakhane
force-pushed
the
leave-room-fix
branch
from
41de9e6
to
231bb51
Compare
brakhane
force-pushed
the
leave-room-fix
branch
from
231bb51
to
997ef54
Compare
|
LGTM |
|
@brakhane thanks, your PR is very useful :) |
|
LGTM |
engelgabriel
added a commit
that referenced
this pull request
Feb 3, 2016
Show confirmation before leaving room
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1543.