Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications improvements #2198

Merged
merged 5 commits into from
Feb 12, 2016
Merged

Notifications improvements #2198

merged 5 commits into from
Feb 12, 2016

Conversation

sampaiodiego
Copy link
Member

  • Fix desktop notifications
  • Removed logic of notifications from sendMessage function
  • Removed logic of "send offline mention emails" from sendMessage function
    • Render message to send by email (require an additional effort to not include copyonly fragments)
    • Send email only to verified addresses
    • Fix bug sending emails to users on every message in a channel he chose to receive desktop notifications on every message
    • Checking statusConnection field to know if the user is not online

@engelgabriel engelgabriel deployed to rocket-chat-pr-2198 February 11, 2016 20:22 Active
@sampaiodiego sampaiodiego mentioned this pull request Feb 11, 2016
Merged
4 tasks
@engelgabriel engelgabriel mentioned this pull request Feb 12, 2016
Closed
@engelgabriel engelgabriel deployed to rocket-chat-pr-2198 February 12, 2016 11:49 Active
@engelgabriel
Copy link
Member

LGTM

@sampaiodiego
Copy link
Member Author

lgtm 😝

sampaiodiego added a commit that referenced this pull request Feb 12, 2016
@sampaiodiego
Merge pull request #2198 from RocketChat/fix-message-notifications
f9fbf8e 
Notifications improvements
@sampaiodiego sampaiodiego merged commit f9fbf8e into develop Feb 12, 2016
@rodrigok
Copy link
Member

LGTM 😸

@engelgabriel engelgabriel deleted the fix-message-notifications branch February 15, 2016 11:45
@Vkat14 Vkat14 mentioned this pull request Oct 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sampaiodiego sampaiodiego

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sampaiodiego @engelgabriel @rodrigok