[FIX] Prevent starting Omni-Queue if Omnichannel is disabled #23396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renatobecker
approved these changes
Oct 7, 2021
KevLehman
approved these changes
Oct 7, 2021
sampaiodiego
pushed a commit
that referenced
this pull request
Oct 14, 2021
Merged
Merged
MartinSchoeler
added a commit
that referenced
this pull request
Dec 7, 2021
* [FIX] LDAP not stoping after wrong password (#23382) * [FIX] MongoDB deprecation link (#23381) * [FIX] resumeToken not working (#23379) * [FIX] Unwanted toastr error message when deleting user (#23372) * check if user exists when accessing canViewAllInfo * Explicitly return null Co-authored-by: Tasso Evangelista <[email protected]> * [FIX] BigBlueButton integration error due to missing file import (#23366) * Chore: Update Apps-Engine version (#23375) * imported migration v240 (#23374) * [FIX] Users' `roles` and `type` being reset to default on LDAP DataSync (#23378) Co-authored-by: Diego Sampaio <[email protected]> * Bump version to 4.0.1 * Prevent starting Omni-Queue if Omnichannel is disabled (#23396) * [FIX][ENTERPRISE] Omnichannel agent is not leaving the room when a forwarded chat is queued (#23404) * [FIX][EE] Omni agent is not leaving the room when a forwarded chat is queued * Apply suggestions from code review * Apply suggestions from code review * [FIX] user/agent upload not working via Apps Engine after 3.16.0 (#23393) * [FIX] Attachment buttons overlap in mobile view (#23377) * Bump version to 4.0.2 * [FIX] Server crashing when Routing method is not available at start (#23473) * Prevent server crash when routing method is not valid * Change way of starting/stopping queue * Friday... * Fix PR comments * Update app/livechat/server/lib/RoutingManager.js Co-authored-by: Murtaza Patrawala <[email protected]> Co-authored-by: Murtaza Patrawala <[email protected]> * [FIX][APPS] Communication problem when updating and uninstalling apps in cluster (#23418) * Fix communication problem when updating apps in cluster * Fix app being removed in multi-instances env problem * Bump version to 4.0.3 * Bump version to 4.1.0-rc.0 * Bump version to 4.1.0-rc.1 * [FIX] Queue error handling and unlocking behavior (#23522) * Error handling on queue processing * add error handling to queue execution and lock timeout * add error handling to queue execution and lock timeout * [FIX] SAML Users' roles being reset to default on login (#23411) * Remove roles update on insertOrUpdateSAMLUser * Check SAML Role Sync setting before updating users' roles * Add rolesSync variable * Add role sync event * Remove isEnterprise check * New code * Updated unit test for the new behavior Co-authored-by: Pierre Lehnen <[email protected]> * Bump version to 4.0.4 * [FIX] OAuth login not working on mobile app (#23541) * [FIX] OAuth login not working on mobile app (#23541) * Bump version to 4.0.5 * Regression: Mail body contains `undefined` text (#23552) Co-authored-by: Diego Sampaio <[email protected]> * Bump version to 4.1.0-rc.2 * Start scheduler after apps have been loaded (#23539) * Revert "Start scheduler after apps have been loaded (#23539)" (#23564) This reverts commit ccbe062. * Bump: fuselage 0.30.1 (#23391) Co-authored-by: dougfabris <[email protected]> * Regression: Routing method not available when called from listeners at startup (#23568) * Regression: Prevent settings from getting updated (#23556) * Bump version to 4.1.0-rc.3 * Regression: Debounce call based on params on omnichannel queue dispatch (#23577) * Bump version to 4.1.0-rc.4 * Bump version to 4.1.0 * Bump version to 4.2.0-develop * [IMPROVE] MKP12 - New UI - Merge Apps and Marketplace Tabs and Content (#23542) * WIP * improve: finished the page merging and routing logic Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: dougfabris <[email protected]> * [FIX] Notifications are not being filtered (#23487) * Add migration to update push notification setting's value * Update mobileNotifications preference to pushNotifications * Chore: Rearrange module typings (#23452) * [NEW] Show on-hold metrics on analytics pages and current chats (#23498) * Show on hold metrics on analytics pages * Add onhold chats to graphs * make colors match cause ocd * change way of calculating open rooms to account for onhold chats * remove onhold chats from open chats * fix colors * fix summarize to remove onhold conversations * i18n: Language update from LingoHub 🤖 on 2021-11-01Z (#23603) * Language update from LingoHub 🤖 Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 * Revert ES Co-authored-by: Robot LingoHub <[email protected]> Co-authored-by: Diego Sampaio <[email protected]> * Start scheduler after apps have been loaded (#23566) * [FIX] App update flow failing in HA setups (#23607) * Update method call for Apps-Engine method * Update Apps-Engine * [FIX] Cannot deactive a regular user if there's only one admin user admin check at setUserActiveStatus * [FIX] "to users" not working in export message (#23576) * fixed export emails * added types * Update app/mailer/server/api.ts Co-authored-by: Matheus Barbosa Silva <[email protected]> * fixed types Co-authored-by: Matheus Barbosa Silva <[email protected]> * [FIX] LDAP users not being re-activated on login (#23627) * [FIX] Advanced LDAP Sync Features (#23608) * [FIX] Advanced LDAP Sync Features * lint fixes * Update ee/server/settings/ldap.ts Co-authored-by: Diego Sampaio <[email protected]> * Update ee/server/settings/ldap.ts Co-authored-by: Diego Sampaio <[email protected]> * Removed unnecessary try..finally Co-authored-by: Diego Sampaio <[email protected]> * [FIX] Advanced LDAP Sync Features (#23608) * [FIX] Advanced LDAP Sync Features * lint fixes * Update ee/server/settings/ldap.ts Co-authored-by: Diego Sampaio <[email protected]> * Update ee/server/settings/ldap.ts Co-authored-by: Diego Sampaio <[email protected]> * Removed unnecessary try..finally Co-authored-by: Diego Sampaio <[email protected]> * [FIX] LDAP users not being re-activated on login (#23627) * [FIX] Cannot deactive a regular user if there's only one admin user admin check at setUserActiveStatus * [FIX] App update flow failing in HA setups (#23607) * Update method call for Apps-Engine method * Update Apps-Engine * Bump version to 4.1.1 * [FIX] Performance issues when running Omnichannel job queue dispatcher (#23661) * Fix Omnichannel job queue dispatcher. * Keep settings validation. * Remove console.log. * Review requests. * Fix default setting value. * [FIX] Omnichannel status being changed on page refresh (#23587) * fix omnichannel status being changed on page refresh * rename key missing * Remove duplicated function from models * [FIX] Omnichannel status being changed on page refresh (#23587) * fix omnichannel status being changed on page refresh * rename key missing * Remove duplicated function from models * [FIX] Performance issues when running Omnichannel job queue dispatcher (#23661) * Fix Omnichannel job queue dispatcher. * Keep settings validation. * Remove console.log. * Review requests. * Fix default setting value. * [FIX] Notifications are not being filtered (#23487) * Add migration to update push notification setting's value * Update mobileNotifications preference to pushNotifications * Bump version to 4.1.2 * [NEW] Permissions for interacting with Omnichannel Contact Center (#23389) * added new permissions and backend api checks for said permission * client-side validation of the permission for showing the contact center button * logo update * Added permissions to the correct place, as well as english description for the permission * Update packages/rocketchat-i18n/i18n/en.i18n.json Co-authored-by: Renato Becker <[email protected]> * changed name of the permission and it's description * Made the permission work with the new settings code * Removing uneeded migration * Added back migrations to create permission * fixing translations * Update packages/rocketchat-i18n/i18n/en.i18n.json Co-authored-by: Renato Becker <[email protected]> Co-authored-by: Caue Felchar <[email protected]> Co-authored-by: Renato Becker <[email protected]> * Chore: Convert Fiber models to async Step 1 (#23633) Co-authored-by: Diego Sampaio <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> * [IMPROVE] Reduce complexity in some functions (#23387) * Chore: Remove useCallbacks (#23696) * Regression: Improve AggregationCursor types (#23692) * fix (#23691) * [IMPROVE] Allow override of default department for SMS Livechat sessions (#23626) * Add departmentName query parameter and override default value * Map livechat SMS sessions based on visitor token and department ID * Update SMS endpoint admin description * Fallback to default department if the target department is invalid * [FIX] Omnichannel business hours page breaking navigation (#23595) * fix business hour persisting UI * eslint * improvement * Update BusinessHoursRouter.js * Update EditBusinessHoursPage.js * remove useState Co-authored-by: Tiago Evangelista Pinto <[email protected]> * fix omnichannel webhooks can't be saved (#23641) * [FIX] Horizontal rule render for inline marked options #23380 * Replace all occurrences of a placeholder on string instead of just first one (#23703) * Chore: Api definitions (#23701) Co-authored-by: Tasso Evangelista <[email protected]> * Chore: Mocha testing configuration (#23706) Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> * [FIX] Fix typo in FR translation (#23711) * Chore: add `no-bidi` rule (#23695) * [FIX] PhotoSwipe crashing on show (#23499) Co-authored-by: dougfabris <[email protected]> * [FIX] Prevent UserAction.addStream without Subscription (#23705) Co-authored-by: Guilherme Gazzo <[email protected]> * [FIX] broken avatar preview when changing avatar (#23659) * [FIX] Fixed E2E default room settings not being honoured (#23468) Co-authored-by: Tasso Evangelista <[email protected]> * Improve naming for twilio department param (#23725) * [NEW] Allow Omnichannel statistics to be collected. (#23694) * partial reconstruction, as progress was lost * Remade code * fixing typo * Update app/statistics/server/lib/statistics.js Co-authored-by: Murtaza Patrawala <[email protected]> * Update app/statistics/server/lib/statistics.js Co-authored-by: Kevin Aleman <[email protected]> * Adding index and fixing broken commit * Applying code suggestion * changed index creation location Co-authored-by: Caue Felchar <[email protected]> Co-authored-by: Murtaza Patrawala <[email protected]> Co-authored-by: Kevin Aleman <[email protected]> * [FIX] Discussions created inside discussions (#23733) * [FIX] Missing user roles in edit user tab (#23734) * [FIX][ENTERPRISE] Private rooms and discussions can't be audited (#23673) * Add support to audit discussions and private rooms * Change tab name to Rooms Co-authored-by: gabriellsh <[email protected]> * Await promise to handle error when attempting to transfer a room (#23739) * [FIX] User logout after reset E2E key #21314 * Chore: Generic Table (#23745) * [FIX] Autofocus on search input in admin (#23738) * [NEW] REST endpoints to manage Omnichannel Business Units (#23750) * add new endpoints to manage business units * change the way deprecations were being returned * change endpoints to be ts * Change to omnichannel * add deprecation warning to old endpoints * Regression: Units endpoint to TS (#23757) * [IMPROVE] Stricter API types (#23735) Co-authored-by: Guilherme Gazzo <[email protected]> * [NEW] Permission for download/uploading files on mobile (#23686) * created new permission * removed unnecessary empty lines * fixed permission import on migration * allow registering by REG_TOKEN environment variable (#23737) * Chore: Type omnichannel models (#23758) Co-authored-by: Guilherme Gazzo <[email protected]> * [NEW] Audio and Video calling in Livechat using Jitsi and WebRTC (#23004) * [NEW] Livechat WebRTC call settings (#22559) * [NEW] Livechat WebRTC call settings * [FIX] Omnichannel Call Settings - Change Livechat call to Video and Audio Call as it will apply to other omnichannels in future - Change Audio and Video Setting alert to description to be conformant with the other settings - Remove unrelated changes(base.css) that got induced unknowingly - Refactor to remove translation for "Jitsi" and "WebRTC" and remove unnecessary dependency on t - Refactor to add return type of handleClick - Add/remove related i18n labels * [FIX] Livechat videoCall api and method * [FIX] Add migrations for webRTC enabled settings and omnichannel call provider * [FIX] 'Jitsi' typo * [NEW] Join call action button (#22689) * [NEW] WebRTC Call Session * [IMPROVEMENT] Use API endpoint instead of method, fix handleClick dependency warning * [FIX] Return updated callStatus, use translation for join call message, remove system logger, make callStatus optional in room interface * [NEW] Join and End Call Action Message Button for Agent * [FIX] Use translation for Call ALready Ended toastr, convert actionLink to tsx * [IMPROVE] Remove redundant callStatus from message collection, Display Call Ended message with call duration * [REF] Use translation for call ended message, Store danger field in db with other action fields, store actionAlignment field in db * [NEW] update call status (#22854) * add code for update call status * remove fourth param Co-authored-by: Murtaza Patrawala <[email protected]> Co-authored-by: Murtaza Patrawala <[email protected]> * [NEW] P2P WebRTC Connection Establishment (#22847) * [NEW] WebRTC P2P Connection with Basic Call UI * [FIX] Set Stream on a stable connection * [FIX] userId typecheck error * [REFACTOR] - Restore type of userId to string by removing `| undefined` - Add translation for visitor does not exist toastr - Set visitorId from room object fetched instead of fetching from livechat widget as query param - Type Checking * [FIX] Running startCall 2 times for agent * [FIX] Call declined Page * [NEW] Control Buttons - mic, cam, expand and end call (#22928) * [NEW] Control Buttons - mic, cam, expand and end call * [REFACTOR] Add an empty file on EOF en18.i18n that was mistakenly removed * [FIX] UI responsiveness (#22934) * [NEW] Control Buttons - mic, cam, expand and end call * [REFACTOR] Add an empty file on EOF en18.i18n that was mistakenly removed * [FIX] UI Responsiveness * [REF] Use const and ternary op * [FIX] Handle decline message action link (#22936) * [NEW] Control Buttons - mic, cam, expand and end call * [REFACTOR] Add an empty file on EOF en18.i18n that was mistakenly removed * [FIX] UI Responsiveness * [REF] Use const and ternary op * [FIX] Action Link not updating when call declined * [FIX] WebRTC_call_declined_message Co-authored-by: Murtaza Patrawala <[email protected]> * [REF] Use a single IF statement to handle status Co-authored-by: Murtaza Patrawala <[email protected]> * [FIX] Call button visible even when chat is queued (#22943) * [FIX] add callstatus attribute in room object (#22959) * [IMPROVE] Attach jitsi link to message object for Livechat (#22690) * [Improve] Attach jitsi link to message object for Livechat (cherry picked from commit c888961da3313de06eaeb0700b7ce0b6371ef469) * Update WebRTCClass.js * [NEW] Webrtc meet page layout (#22932) * [NEW] Control Buttons - mic, cam, expand and end call * webrtc meet page desgin * [REFACTOR] Add an empty file on EOF en18.i18n that was mistakenly removed * [FIX] UI Responsiveness * [FIX] Action Link not updating when call declined * webrtc meet page desgin * [FIX] Remote user avatar screen and video switching * fix-alert * fix 2 aletrs * improve codebase * make ui responsive * fix issue * Add call timer component + minor refactoring * some css changes Co-authored-by: Dhruv Jain <[email protected]> Co-authored-by: murtaza98 <[email protected]> Co-authored-by: Murtaza Patrawala <[email protected]> * Add migration * Changing files to tsx * Update default value for setting -Jitsi_Open_New_Window * Update invalid-livechat-config issue * Fix typescript errors * Fix build errors caused by new room prop - webRtcCallStartTime * Simplify call duration calculation logic * Add definition PUT method for REST on client Co-authored-by: Dhruv Jain <[email protected]> Co-authored-by: Deepak Agarwal <[email protected]> Co-authored-by: Dhruv Jain <[email protected]> * [IMPROVE] Engagement Dashboard (#23547) Co-authored-by: matheusbsilva137 <[email protected]> * [FIX][ENTERPRISE] OAuth "Merge Roles" removes roles from users (#23588) * Fix OAuth 'Merge Roles' * Add setting to control which roles to sync Co-authored-by: pierre-lehnen-rc <[email protected]> * [FIX] New specific endpoint for contactChatHistoryMessages with right permissions (#23533) Co-authored-by: Kevin Aleman <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> * [IMPROVE] Improve the add user drop down for add a user in create channel modal for UserAutoCompleteMultiple (#23766) * Adding the new UI * Correcting * Adding the key * Adding the listenners * Lint * Lint * Lint * adding a eslint-disable * lint * lint Co-authored-by: Jean <[email protected]> Co-authored-by: Jeanstaquet <[email protected]> * Chore: Bump livechat to 1.10 (#23768) * Chore: add index on appId + associations for apps_persistence collection (#23675) * [NEW] Rate limiting for user registering (#23732) * users.register setting + rate limiting * refact rate limiting strategy * remove empty line * method rate limiting + description + i18n * update + settings.watch on rest api * removed duplicated setting * fixed update setting value on rest api * refresh registerUser method on setting update + i18n * removed useless object * removed empty method * fixed exception in server launch * renamed setting * updated numRequestsAllowed in users.register * i18n update * lint * moved settings.watch to endpoint * created a new settings.watch for methods + improved rate limiter dictionary method * [NEW] Enable LDAP manual sync to deployments without EE license (#23761) * [NEW] Enable LDAP manual sync to deployments without EE license * Small code refactor * Update api.ts * Create api.ts * Fix Review Co-authored-by: Guilherme Gazzo <[email protected]> * Chore: Remove duplicated 'name' key from rate limiter logs (#23771) * Regression: Fix sendMessagesToAdmins not in Fiber (#23770) * [FIX] Registration not possible when any user is blocked for multiple failed logins (#23565) * Chore: Update settings.ts (#23769) Co-authored-by: Diego Sampaio <[email protected]> * Bump version to 4.2.0-rc.0 * Regression: Fix LDAP sync route (#23775) Co-authored-by: Diego Sampaio <[email protected]> * Regression: Fix incorrect API path for Livechat calls (#23778) * Bump version to 4.2.0-rc.1 * Regression: Fix sort param on omnichannel endpoints (#23789) * Regression: Include files on EE services build (#23793) * Bump version to 4.2.0-rc.2 * Regression: Add @rocket.chat/emitter to EE services (#23802) * Bump version to 4.2.0-rc.3 * Regression: Current Chats not Filtering (#23803) * Regression: Mark Livechat WebRTC video calling as alpha (#23813) * i18n: Language update from LingoHub 🤖 on 2021-11-29Z (#23812) * Language update from LingoHub 🤖 Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 Co-authored-by: Diego Sampaio <[email protected]> * Regression: "When is the chat busier" and "Users by time of day" charts are not working (#23815) * Regression: Fix incorrect API path for Livechat calls (#23778) * Update ee/client/views/admin/engagementDashboard/users/UsersByTimeOfTheDaySection.tsx Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: Murtaza Patrawala <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> * [FIX] LDAP users being disabled when an AD security policy is enabled (#23820) * Regression: Add trash to raw models (#23774) Co-authored-by: Guilherme Gazzo <[email protected]> * Bump version to 4.2.0-rc.4 * Bump version to 4.2.0 * Bump version to 4.3.0-develop * [FIX] error after properly deleting user from admin panel #23690 * Chore: Replace new typography (#23756) Co-authored-by: Guilherme Gazzo <[email protected]> * Chore: Change Menu props to accept next fuselage version (#23839) * [IMPROVE] Rewrite remove room invite modal #23781 * [FIX] Missing custom user status ellipsis (#23831) * [FIX] Add CSP to authorize auto-close of CAS login window (#23215) * [FIX] Add CSP to authorize auto-close of CAS login window * Update cors.js Co-authored-by: pierre-lehnen-rc <[email protected]> * [NEW] Create new setting to clean local storage at end of chats(#23821) * [FIX] No hover effect for items in kebab menu. #23712 * Chore: Create script to add new migrations (#23822) * Fix inactive user creation (#23859) * [FIX] Wrong button for non trials apps (#23861) * i18n: Language update from LingoHub 🤖 on 2021-12-06Z (#23873) * Language update from LingoHub 🤖 Project Name: Rocket.Chat Project Link: https://translate.lingohub.com/rocketchat/dashboard/rocket-dot-chat User: Robot LingoHub Easy language translations with LingoHub 🚀 Co-authored-by: Diego Sampaio <[email protected]> * Regression: Missing padding in popover with custom template (#23877) Co-authored-by: Rodrigo Nascimento <[email protected]> Co-authored-by: Diego Sampaio <[email protected]> Co-authored-by: Leonardo Ostjen Couto <[email protected]> Co-authored-by: Tasso Evangelista <[email protected]> Co-authored-by: wolbernd <[email protected]> Co-authored-by: Douglas Gubert <[email protected]> Co-authored-by: Matheus Barbosa Silva <[email protected]> Co-authored-by: Murtaza Patrawala <[email protected]> Co-authored-by: Aman-Maheshwari <[email protected]> Co-authored-by: Kevin Aleman <[email protected]> Co-authored-by: Thassio Victor <[email protected]> Co-authored-by: Pierre Lehnen <[email protected]> Co-authored-by: pierre-lehnen-rc <[email protected]> Co-authored-by: Guilherme Gazzo <[email protected]> Co-authored-by: dougfabris <[email protected]> Co-authored-by: Henrique Guimarães Ribeiro <[email protected]> Co-authored-by: lingohub[bot] <69908207+lingohub[bot]@users.noreply.github.com> Co-authored-by: Robot LingoHub <[email protected]> Co-authored-by: Duda Nogueira <[email protected]> Co-authored-by: Renato Becker <[email protected]> Co-authored-by: Cauê Felchar <[email protected]> Co-authored-by: Caue Felchar <[email protected]> Co-authored-by: Tiago Evangelista Pinto <[email protected]> Co-authored-by: Aditya Bhardwaj <[email protected]> Co-authored-by: Lucas Dousse <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: siva <[email protected]> Co-authored-by: gabriellsh <[email protected]> Co-authored-by: Aaron Ogle <[email protected]> Co-authored-by: Dhruv Jain <[email protected]> Co-authored-by: Deepak Agarwal <[email protected]> Co-authored-by: Dhruv Jain <[email protected]> Co-authored-by: matheusbsilva137 <[email protected]> Co-authored-by: Jean <[email protected]> Co-authored-by: Jeanstaquet <[email protected]> Co-authored-by: Martin Schoeler <[email protected]> Co-authored-by: Júlia Jaeger Foresti <[email protected]> Co-authored-by: Guillaume Colson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Whenever the Routing system setting changes, and omnichannel is disabled, then we shouldn't start the queue.
Issue(s)
Steps to test or reproduce
Further comments