Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 4.0.4 #23532

Merged
merged 3 commits into from
Oct 21, 2021
Merged

Release 4.0.4 #23532

merged 3 commits into from
Oct 21, 2021

Conversation

sampaiodiego
Copy link
Member

2021-10-21 · 2 🐛 · 3 👩‍💻👨‍💻

Engine versions

  • Node: 12.22.1
  • NPM: 6.14.1
  • MongoDB: 3.6, 4.0, 4.2, 4.4, 5.0
  • Apps-Engine: 1.28.0

🐛 Bug fixes

  • Queue error handling and unlocking behavior (#23522)

  • SAML Users' roles being reset to default on login (#23411)

    • Remove roles field update on insertOrUpdateSAMLUser function;

    • Add SAML syncRoles event;

👩‍💻👨‍💻 Core Team 🤓

KevLehman and others added 3 commits October 21, 2021 18:03
@KevLehman @sampaiodiego
[FIX] Queue error handling and unlocking behavior (#23522)
ed96030 
* Error handling on queue processing

* add error handling to queue execution and lock timeout

* add error handling to queue execution and lock timeout
@matheusbsilva137 @pierre-lehnen-rc @sampaiodiego
[FIX] SAML Users' roles being reset to default on login (#23411)
761b874 
* Remove roles update on insertOrUpdateSAMLUser

* Check SAML Role Sync setting before updating users' roles

* Add rolesSync variable

* Add role sync event

* Remove isEnterprise check

* New code

* Updated unit test for the new behavior

Co-authored-by: Pierre Lehnen <[email protected]>
@sampaiodiego
Bump version to 4.0.4
f223443
@sampaiodiego sampaiodiego requested review from a team October 21, 2021 21:11
@sampaiodiego sampaiodiego merged commit 17db619 into master Oct 21, 2021
@sampaiodiego sampaiodiego deleted the release-4.0.4 branch October 21, 2021 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sampaiodiego @ggazzo @KevLehman @matheusbsilva137