Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVE] Changed the buttons of Integrations #24110

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

[IMPROVE] Changed the buttons of Integrations #24110

wants to merge 5 commits into from
+21 −14

Conversation

aswiniip
Copy link
Contributor

@aswiniip aswiniip commented Jan 5, 2022 •
edited by dougfabris
Loading

Proposed changes (including videos or screenshots)

  1. In the EditIncomingWebhook page,
  • The save and edit buttons were always active and clickable so i changed it such that it is disabled when the form doesn't have any unsaved changes.
  • Changed the button type of save to primary (taking inspiration from Edit-custom-emoji buttons)(Refer "Further comments" below)
  1. In the EditOutgoingWebhook page,
  • The save and edit buttons were always active and clickable so i changed it such that it is disabled when the form doesn't have any unsaved changes.
  • Changed the button type of save to primary (taking inspiration from Edit-custom-emoji buttons)(Refer "Further comments" below)
  1. In the NewIncomingWebhook page,
  • The save and edit buttons were always active and clickable so i changed it such that it is disabled when the form doesn't have any unsaved changes.
  • Changed the button type of save to primary (taking inspiration from Edit-custom-emoji buttons)(Refer "Further comments" below)
  1. In the NewOutgoingWebhook page,
  • Reset button was missing. So added it and made it such that it gets disabled when there are no unsaved changes.
  • The save button was always active and clickable so i changed it such that it is disabled when the form doesn't have any unsaved changes.
  • Changed the button type of save to primary (taking inspiration from Edit-custom-emoji buttons)(Refer "Further comments" below)

Issue(s)

Fixes RocketChat/feature-requests#702

Steps to test or reproduce

Further comments

Inspiration: Edit-custom-emoji buttons

I thought the buttons should follow the same type of layout/color to maintain uniformity

Screenshot from 2022-01-06 02-27-31

@aswiniip aswiniip mentioned this pull request Jan 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
communityPR Invalid PR Title stat: conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Support for reset button in Integration
4 participants
@aswiniip @dudanogueira @ggazzo @sampaiodiego