[FIX] Validate room access #24534
Merged
[FIX] Validate room access #24534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albuquerquefabio
changed the title
albuquerquefabio
changed the title
albuquerquefabio
changed the title
…RocketChat/Rocket.Chat into fix/validate-direct-room-access
…RocketChat/Rocket.Chat into fix/validate-direct-room-access
matheusbsilva137
requested changes
Mar 22, 2022
github-actions
bot
added
the
stat: ready to merge
pierre-lehnen-rc
requested changes
Jun 22, 2022
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
github-actions
bot
added
the
stat: ready to merge
|
This pull request introduces 2 alerts when merging 0d5cca0 into d9ffbd6 - view on LGTM.com new alerts:
|
albuquerquefabio
added
stat: ready to merge
sampaiodiego
approved these changes
Jun 29, 2022
pierre-lehnen-rc
approved these changes
Jun 30, 2022
ggazzo
added
stat: ready to merge
ggazzo
approved these changes
Jul 1, 2022
gabriellsh
added a commit
that referenced
this pull request
Jul 4, 2022
* 'develop' of github.com:RocketChat/Rocket.Chat: (29 commits) Chore: move fork of cas module to the monorepo (#26107) Chore: Add Agenda fork to the monorepo (#25681) Chore: Bump deps (#25624) [NEW][ENTERPRISE] Device Management (#25791) Chore: `refactor/tsc-perf` (#26040) [BREAK] Upgrade to version 5.0 can be done only from version 4.x (#26100) [BREAK] Remove support to old MongoDB versions (#26098) [NEW] Matrix Federation UX improvements (#25847) Regression: en.i18n.json spaces [NEW][ENTERPRISE] Introducing dial pad component into sidebar, calls table, contextual bar (#26081) Chore: Settings UI issue (#26053) Chore: Adding default message parser template (#26064) Regression: [VideoConference] If the caller loses connection, direct calls are never canceled (#26099) Chore: Handle errors on index creation (#26094) Chore: fix watermark condition (#26095) [FIX] Validate room access (#24534) [BREAK] VideoConference (#25570) [FIX] Undefined headers on API Client (#26083) Regression: Add Error boundary to katex render component (#26067) Chore: Allow endpoints to optionally require authentication (#26084) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The request must be blocked If the user has no permission to view rooms.
Issue(s)
You can access Direct Rooms even if "View Direct Room" permissions are disabled.
You can access Public Rooms even if "View Public Room" permissions are disabled.
You can access Private Rooms even if "View Private Room" permissions are disabled.
You can access Omnichannel Rooms even if "View Omnichannel Room" permissions are disabled.
Steps to test or reproduce
Further comments