-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Announcement modal horizontal scrollbar #24889
Merged
ggazzo
merged 7 commits into
RocketChat:develop
from
Shivansh2287:announcementModalScroll
Aug 22, 2024
Merged
fix: Announcement modal horizontal scrollbar #24889
ggazzo
merged 7 commits into
RocketChat:develop
from
Shivansh2287:announcementModalScroll
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dougfabris @tassoevan please review |
🦋 Changeset detectedLatest commit: 4da59b4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is ready to merge! 🎉 |
dougfabris
changed the title
[IMPROVE] announcement modal scrollbar fix
fix: Announcement modal horizontal scrollbar
Aug 22, 2024
dougfabris
added
the
stat: QA assured
Means it has been tested and approved by a company insider
label
Aug 22, 2024
dionisio-bot
bot
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Aug 22, 2024
dougfabris
approved these changes
Aug 22, 2024
KevLehman
added
stat: ready to merge
PR tested and approved waiting for merge
and removed
stat: ready to merge
PR tested and approved waiting for merge
labels
Aug 22, 2024
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
Co-authored-by: dougfabris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
communityPR
stat: QA assured
Means it has been tested and approved by a company insider
stat: ready to merge
PR tested and approved waiting for merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including screenshots)
before
after
Issue(s)
Fixes #24888
Steps to test or reproduce
Further comments