Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Announcement modal horizontal scrollbar #24889

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

Shivansh2287
Copy link
Contributor

@Shivansh2287 Shivansh2287 commented Mar 20, 2022

Proposed changes (including screenshots)

before

image

after

image

Issue(s)

Fixes #24888

Steps to test or reproduce

Further comments

@Shivansh2287
Copy link
Contributor Author

@dougfabris @tassoevan please review

@dougfabris dougfabris requested a review from a team as a code owner August 22, 2024 14:23
Copy link

changeset-bot bot commented Aug 22, 2024

🦋 Changeset detected

Latest commit: 4da59b4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Aug 22, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dougfabris dougfabris changed the title [IMPROVE] announcement modal scrollbar fix fix: Announcement modal horizontal scrollbar Aug 22, 2024
@dougfabris dougfabris added this to the 6.12 milestone Aug 22, 2024
@dougfabris dougfabris added the stat: QA assured Means it has been tested and approved by a company insider label Aug 22, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 22, 2024
@KevLehman KevLehman added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 22, 2024
@ggazzo ggazzo merged commit c079498 into RocketChat:develop Aug 22, 2024
34 of 36 checks passed
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
communityPR stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] horizontal scrollbar in announcement section
5 participants