-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMPROVE] Pinned Messages in E2E rooms #25325
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25325 +/- ##
===========================================
- Coverage 55.59% 53.70% -1.90%
===========================================
Files 2407 1112 -1295
Lines 52905 28341 -24564
Branches 10866 4000 -6866
===========================================
- Hits 29415 15220 -14195
+ Misses 20886 12291 -8595
+ Partials 2604 830 -1774
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of passing the prop rid
to be used to decrypt the message, try to use one of the existing hooks to get the rid
, useUserRoom
or useRoom
You can also detach the useRoom
hook from RoomContext
if needed
apps/meteor/client/components/message/Attachments/DefaultAttachment.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/components/message/Attachments/DefaultAttachment.tsx
Outdated
Show resolved
Hide resolved
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Closed in favor of - #32380 |
Proposed changes (including videos or screenshots)
Before
After
In Pinned Messages contextual bar -
If we don't have E2EE keys -
Issue(s)
Steps to test or reproduce
Further comments