Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW] Ability for Rocket.Chat Apps to delete messages (Derived from #24806) #25515

Closed
wants to merge 2 commits into from

Conversation

murtaza98
Copy link
Contributor

@murtaza98 murtaza98 commented May 15, 2022

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Corresponding apps-engine PR: RocketChat/Rocket.Chat.Apps-engine#507

@debdutdeb
Copy link
Member

debdutdeb commented Jan 5, 2023

I'm thinking whether this path should just be app deleting a message or any user deleting the message .. kinda like how we now send a message through an app - need to explicitely set the user performing the action, which can either be an user or the app user, set by the app itself.

ps: apart from ^ the pr looks good.

@murtaza98
Copy link
Contributor Author

I'm thinking whether this path should just be app deleting a message or any user deleting the message .. kinda like how we now send a message through an app - need to explicitely set the user performing the action, which can either be an user or the app user, set by the app itself.

That's a good point! Perhaps we can do the same thing here by adding a param asking for the user who is deleting the message. I'd like to keep that optional and use app-user if its not provided. WDYT?

@murtaza98 murtaza98 closed this Jun 12, 2023
@debdutdeb debdutdeb deleted the apps/delete-msg branch June 12, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants