Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Remove duplicated property _USERNAMES from createDirectRoom.ts #26087

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

felipe-rod123
Copy link
Contributor

Proposed changes (including videos or screenshots)

This pull request removes the duplicated property _USERNAMES from apps/meteor/app/lib/server/functions/createDirectRoom.ts, using only the existing property roomInfo.usernames.

Issue(s)

Steps to test or reproduce

Further comments

@felipe-rod123 felipe-rod123 requested review from sampaiodiego and a team July 1, 2022 00:49
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 1, 2022
@kodiakhq kodiakhq bot merged commit aeb534f into develop Jul 1, 2022
@kodiakhq kodiakhq bot deleted the fix/createDirectRoom-usernames branch July 1, 2022 02:12
@murtaza98 murtaza98 mentioned this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants