Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Unavailable devices in unsupported browsers #26174

Merged
merged 7 commits into from
Jul 12, 2022

Conversation

MartinSchoeler
Copy link
Contributor

This PR disables device changes in browsers that not support the setSinkId method, and therefore does not support device changes directly from the browser

Screen Shot 2022-07-07 at 11 18 10 AM

I've decided to test if the setSinkId is available instead of listing browsers that supported or not, this way if a browser starts/stops supporting it, we don't have to do anything, and there is also firefox, where you can enable it as an optional feature.

@MartinSchoeler MartinSchoeler requested a review from a team as a code owner July 7, 2022 14:34
@lgtm-com
Copy link

lgtm-com bot commented Jul 7, 2022

This pull request introduces 2 alerts when merging a04bd19 into 02d9dd9 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@KevLehman
Copy link
Contributor

🤔 since the description goes to release, can you put a note mentioning that there's "experimental" support for the feature on Firefox through flags? https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/setSinkId. Not recommended for longer use, but at least for trying out.

@MartinSchoeler
Copy link
Contributor Author

🤔 since the description goes to release, can you put a note mentioning that there's "experimental" support for the feature on Firefox through flags? https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/setSinkId. Not recommended for longer use, but at least for trying out.

I wanted to avoid talking about browsers though, since today is experimental but tomorrow it might change

KevLehman
KevLehman previously approved these changes Jul 11, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 12, 2022
@ggazzo ggazzo merged commit 70bf57b into develop Jul 12, 2022
@ggazzo ggazzo deleted the firefox-device-management branch July 12, 2022 20:56
@alvaropmello alvaropmello added this to the 5.0.0 milestone Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants