-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression: Unavailable devices in unsupported browsers #26174
Conversation
Co-authored-by: Guilherme Gazzo <[email protected]>
Co-authored-by: Guilherme Gazzo <[email protected]>
This pull request introduces 2 alerts when merging a04bd19 into 02d9dd9 - view on LGTM.com new alerts:
|
🤔 since the description goes to release, can you put a note mentioning that there's "experimental" support for the feature on Firefox through flags? https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/setSinkId. Not recommended for longer use, but at least for trying out. |
I wanted to avoid talking about browsers though, since today is experimental but tomorrow it might change |
Co-authored-by: Kevin Aleman <[email protected]>
Translation key changed, but not here.
Missing target/rel props for link
This PR disables device changes in browsers that not support the
setSinkId
method, and therefore does not support device changes directly from the browserI've decided to test if the
setSinkId
is available instead of listing browsers that supported or not, this way if a browser starts/stops supporting it, we don't have to do anything, and there is also firefox, where you can enable it as an optional feature.