Regression: Remove 4.0 version banner

[hugocostadev]

Proposed changes (including videos or screenshots)

Created a migration to disable and dismiss for all users the old 4.0 version banner.
It happened when a new admin user has been added.

Issue(s)

Steps to test or reproduce

Further comments

[sampaiodiego]

I'm sorry, but where is this banner coming from?

I'd like to understand as this doesn't look like to be the best implementation for this purpose.

[hugocostadev]

I'm sorry, but where is this banner coming from?

I'd like to understand as this doesn't look like to be the best implementation for this purpose.

Hi @sampaiodiego, this banner was added in a previous migration (v231) and the migration v232 tried to dismiss, but the problem is that the v232 migration just dismisses for admins if a user is added as admin after this migration execution the user is able to see the banner. This issue can be verified at: https://unstable.rocket.chat/

[sampaiodiego]

thx @hugocostadev for the explanation.. so if I get it right, now the ideia is to dismiss the banner to everyone, right? in this case, we don't need to actually dismiss, we can just disable the banner itself.. once it is disabled, no one will see it.

and to disable it, since we're doing it in a migration, we can do it calling the model directly.. the query can be something like:

Banners.updateOne({
  'view.blocks.0.text.text': /authentication\-changes/,
  active: { $ne: false }
}, {
  $set: {
    active: false,
    inactivedAt: new Date(),
  },
})

that should be enough :)

btw, we can use this banner as an example why we should chose for specific IDs when we create a banner ourselves, so it is much easier to deal with it if needed.

I'm going to add other comments to the code, to explain what we should avoid in the proposed solution

[sampaiodiego]

I've explained what we should avoid and why..

so please, you can change everything starting from line 26, and perform only the Banner from my previous comment:

Banners.updateOne({
  'view.blocks.0.text.text': /authentication\-changes/,
  active: { $ne: false }
}, {
  $set: {
    active: false,
    inactivedAt: new Date(),
  },
})

[hugocostadev]

I've explained what we should avoid and why..

so please, you can change everything starting from line 26, and perform only the Banner from my previous comment:

Banners.updateOne({
  'view.blocks.0.text.text': /authentication\-changes/,
  active: { $ne: false }
}, {
  $set: {
    active: false,
    inactivedAt: new Date(),
  },
})

Perfect Diego, I got it! Thanks so much for your explanations, indeed this is a much cleaner and wise solution