Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Matrix Federation regressions #26283

Merged
merged 20 commits into from
Jul 20, 2022
Merged

Regression: Matrix Federation regressions #26283

merged 20 commits into from
Jul 20, 2022

Conversation

MarcosSpessatto
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@MarcosSpessatto MarcosSpessatto added this to the 5.0.0 milestone Jul 15, 2022
@MarcosSpessatto MarcosSpessatto self-assigned this Jul 15, 2022
@MarcosSpessatto MarcosSpessatto requested review from a team as code owners July 15, 2022 20:01
@MarcosSpessatto @ggazzo
Regression: Do not allow non-owners edit rooms or add/remove users on…
c680bf4 
… federated rooms (#26263)

* fix: do not allow non-owners edit or add users on federated rooms

* fix: do not allow non-owners to remove users from federated rooms

* fix: apply suggestion from review
@MarcosSpessatto @ggazzo
[FIX] Do not prevent external users from being added in channels on CE (
d90308d 
#26281)
sampaiodiego
sampaiodiego approved these changes Jul 19, 2022
View reviewed changes
Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what happened since last commit, lots of files removed.

anyways, looking forward for the type casting removals, as right now they feel very loose.

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Jul 20, 2022
@casalsgh
Copy link
Contributor

QA Tested. Bug found for a minor item and we'll proceed with known issue.

@casalsgh casalsgh added stat: needs QA stat: ready to merge PR tested and approved waiting for merge stat: QA tested and removed stat: QA tested stat: ready to merge PR tested and approved waiting for merge stat: needs QA labels Jul 20, 2022
@ggazzo ggazzo added stat: needs QA stat: QA tested stat: ready to merge PR tested and approved waiting for merge and removed stat: QA tested stat: ready to merge PR tested and approved waiting for merge stat: needs QA labels Jul 20, 2022
@ggazzo ggazzo merged commit b8097fa into develop Jul 20, 2022
@ggazzo ggazzo deleted the feat/federation branch July 20, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

@alansikora alansikora Awaiting requested review from alansikora

@gabriellsh gabriellsh Awaiting requested review from gabriellsh

Assignees

@MarcosSpessatto MarcosSpessatto

Labels
squad: federation stat: QA tested stat: ready to merge PR tested and approved waiting for merge type: regression
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@MarcosSpessatto @casalsgh @sampaiodiego @gabriellsh @ggazzo @carlosrodrigues94