Chore: create roomNameExists endpoint #26386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging 42ffd4a into 3ca01a8 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## develop #26386 +/- ##
===========================================
+ Coverage 38.05% 38.20% +0.15%
===========================================
Files 749 762 +13
Lines 18667 18857 +190
Branches 1455 1459 +4
===========================================
+ Hits 7103 7204 +101
- Misses 11343 11427 +84
- Partials 221 226 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
This pull request introduces 1 alert when merging 6f18e0d into 9e5c9a2 - view on LGTM.com new alerts:
|
ggazzo
approved these changes
Aug 10, 2022
ggazzo
added
stat: QA skipped
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Aug 12, 2022
…hreads * 'develop' of github.com:RocketChat/Rocket.Chat: (34 commits) Chore: update fuselage rounded edition (#26540) [FIX] LDAP fails to sync teams when the user DN has escaped characters. (#26535) [FIX] Allow normal user to open apps contextual bar (#26495) Chore: restrict `.only` (#26537) [FIX] Endpoints not working when using "Use Real Name" setting (#26530) [NEW] `Home` page (#25734) Chore: ModalFooterControllers adoption (#26445) Chore: create roomNameExists endpoint (#26386) Chore: Improve test for livechat (#26527) Chore: Fix UiKit dependency issue for Livechat (#26534) [FIX] Too many REST API requests (#26330) Chore: Mocha handling multiple React instances (#26513) Chore: Convert `LivechatCustomField` model to raw model (#26446) i18n: Language update from LingoHub 🤖 on 2022-08-08Z (#26508) [FIX] Open team after room not found page (#26264) Chore: Refactor ReportMessage Modal to React Component (#26478) Chore: Fix lint issues (#26531) [FIX] Don't wrap wrap up notes (#26375) [IMPROVE] OTR refactoring (#24757) [FIX] Prevent VoIP issues during disconnection when network failed (#26321) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Created the missing rest endpoint 'roomNameExists' for
apps/meteor/client/sidebar/header/CreateChannel.tsx, on the packages/rest-typings/src/v1/ folder.Issue(s)
Steps to test or reproduce
Further comments