[FIX] Not allowed error in discussion room with a private parent channel #26394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #26394 +/- ##
========================================
Coverage 37.97% 37.98%
========================================
Files 778 779 +1
Lines 18854 18860 +6
Branches 1932 1933 +1
========================================
+ Hits 7160 7164 +4
- Misses 11400 11403 +3
+ Partials 294 293 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Actually, if the parent room is a public channel, the user does have permission to fetch the info through the endpoint. We should only change the fetch to not dispatch an error message. |
gabriellsh
previously approved these changes
Aug 22, 2022
…/room * 'fix/room' of github.com:RocketChat/Rocket.Chat: Chore: Create teams management tests (#26578)
gabriellsh
approved these changes
Aug 22, 2022
ggazzo
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Aug 24, 2022
…ove/otr-message * 'develop' of github.com:RocketChat/Rocket.Chat: Regression: Add alsoSendThreadToChannel to user settings api (#26663) [IMPROVE] Spotlight search user results (#26599) [FIX] Slack User CSV importer not working (#26629) Chore: Importer rest types, meteor methods to TS and API unit tests (#26284) [NEW] Adding oauth crud on the rocket.chat side (#26220) [NEW] allow ephemeral messages to receive a specific id (#26118) [FIX] MDM content alignment (#26665) Chore: Permissions check per endpoint/method (#26419) Regression: CI (#26658) [FIX] Not allowed error in discussion room with a private parent channel (#26394) Chore: Fix grammatical typo when only one message is pruned (#21902) [FIX] Agents (with user status offline & omni-status as available) not able to take or forward chat (#26575) i18n: Language update from LingoHub 🤖 on 2022-08-22Z (#26645) Chore: Add license env var to ee tests (#26650) Chore: Move `Card` and related components to `@rocket.chat/ui-client` (#26653) Regression: Custom status loading forever in Usercard (#26656) [FIX] Current Chat Custom Field Filter (#26200) Chore: Migrate modules related to `room` template to TypeScript (#25881) Chore: Create teams management tests (#26578)
csuadev
pushed a commit
that referenced
this pull request
Aug 26, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
If a user is added to a discussion that was created under a private group as its parent channel and that user does not have access to the parent private group, the user keeps getting a "not-allowed" error banner whenever they open the discussion.
Sometimes the error
too-many-requestis thrown (429).The
ParentRoomWithEndpointDatacomponent was calling therooms.infoas a fallback when the parent component didn't have theSubscription. This fallback was fine before when the room component wasn't await forSubscription. Nowadays this fallback doesn't make sense because the room already waits forSubscriptionto load, the current fallback is only being used when the user doesn't have permission to view the info in the parent room.