Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Empty results on im.list endpoint #26438

Merged
merged 3 commits into from
Aug 2, 2022
Merged

Conversation

albuquerquefabio
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@albuquerquefabio albuquerquefabio requested a review from a team as a code owner August 2, 2022 03:04
@albuquerquefabio albuquerquefabio changed the title Fix: Endpoint Im list [FIX] Endpoint Im list Aug 2, 2022
@codecov
Copy link

codecov bot commented Aug 2, 2022

Codecov Report

Merging #26438 (2fe5675) into develop (133aa10) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 2fe5675 differs from pull request most recent head ae34c15. Consider uploading reports for the commit ae34c15 to get more accurate results

@@             Coverage Diff             @@
##           develop   #26438      +/-   ##
===========================================
- Coverage    39.10%   39.05%   -0.05%     
===========================================
  Files          748      748              
  Lines        18647    18647              
  Branches      1424     1424              
===========================================
- Hits          7291     7283       -8     
- Misses       11133    11142       +9     
+ Partials       223      222       -1     
Flag Coverage Δ
e2e 39.05% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...views/room/MessageList/lib/isMessageFirstUnread.ts 50.00% <0.00%> (-16.67%) ⬇️
...discussion/client/createDiscussionMessageAction.ts 31.25% <0.00%> (-12.50%) ⬇️
apps/meteor/app/ui-utils/client/lib/RoomManager.js 76.00% <0.00%> (-3.43%) ⬇️
...teor/app/ui-utils/client/lib/RoomHistoryManager.js 51.44% <0.00%> (-0.97%) ⬇️
...ached-collection/client/models/CachedCollection.js 85.41% <0.00%> (-0.53%) ⬇️
apps/meteor/app/ui/client/views/app/room.js 49.38% <0.00%> (-0.21%) ⬇️
apps/meteor/app/ui-login/client/login/form.js 73.85% <0.00%> (+0.65%) ⬆️
...ps/meteor/app/ui-login/client/username/username.js 52.63% <0.00%> (+1.05%) ⬆️
apps/meteor/client/lib/meteorCallWrapper.ts 100.00% <0.00%> (+3.57%) ⬆️
apps/meteor/app/ui-utils/client/lib/openRoom.js 78.43% <0.00%> (+3.92%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@sampaiodiego sampaiodiego added this to the 4.8.3 milestone Aug 2, 2022
@sampaiodiego sampaiodiego changed the title [FIX] Endpoint Im list [FIX] Empty results on im.list endpoint Aug 2, 2022
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Aug 2, 2022
@kodiakhq kodiakhq bot merged commit f555889 into develop Aug 2, 2022
@kodiakhq kodiakhq bot deleted the fix/endpoint-im-list branch August 2, 2022 15:17
murtaza98 pushed a commit that referenced this pull request Aug 2, 2022
@murtaza98 murtaza98 mentioned this pull request Aug 2, 2022
murtaza98 pushed a commit that referenced this pull request Aug 2, 2022
@murtaza98 murtaza98 mentioned this pull request Aug 2, 2022
gabriellsh added a commit that referenced this pull request Aug 2, 2022
…history

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  [IMPROVE] validateParams to accept different validators per request method (#26357)
  Regression: Fix spacing problem on AppStatus component (#26421)
  Chore: Convert client/views/account/security folder to ts (#26413)
  i18n: Makes the text less ambiguous (#20895)
  Chore: Missing some English translation keywords (#20131)
  Chore: Exclude private/public folders from typecheck (#26399)
  [NEW] Marketplace apps page new list view layout (#26181)
  Chore: Rewrite custom OAuth Modals to react (#26204)
  i18n: Manual sync from LingoHub (#26397)
  Chore: Options in BaseRaw model could possibly be undefined (#26395)
  [IMPROVE] Use single change stream to watch DB changes (#26336)
@sampaiodiego sampaiodiego modified the milestones: 4.8.3, 5.0.2 Aug 3, 2022
carlosrodrigues94 pushed a commit that referenced this pull request Aug 3, 2022
gabriellsh added a commit that referenced this pull request Aug 4, 2022
…ove-e2ee-threadlist

* 'develop' of github.com:RocketChat/Rocket.Chat: (200 commits)
  [FIX] Undefined MediaDevices error on HTTP (#26396)
  Chore: Codecov threshold (#26477)
  Chore: Tests intermitences (#26464)
  [FIX] Don't give errors on outbound voip call Request Terminated (#26373)
  Chore: Use Docker compose on CI (#26437)
  [FIX] DialPad call button from end to center (#26459)
  Chore: Parallelize e2e tests (#26390)
  [IMPROVE] use enter key to call using DialPad (#26454)
  Chore: Accounts/token to TS (#26434)
  Chore: Purge some unused modules (#26447)
  i18n: Language update from LingoHub 🤖 on 2022-08-01Z (#26429)
  Chore: Add end-to-end tests to teams listing in the `directory` endpoint (#26347)
  Chore: Cache playwright (#26432)
  [FIX] Empty results on `im.list` endpoint (#26438)
  [IMPROVE] Upgrade nivo and React Query (#26338)
  Chore: Upgrade Fuselage packages to next dist-tag (#26435)
  Chore: Omnichannel endpoints e2e tests (#26376)
  Chore: Refactor UserInfo to typescript (#26323)
  Chore: Rewrite Location modal to React (#26196)
  Chore: Rewrite SaveToWebdav Modal to React Component (#24365)
  ...
murtaza98 pushed a commit that referenced this pull request Aug 8, 2022
@murtaza98 murtaza98 mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants