-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Check if messsage.replies exist on new message template #26652
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #26652 +/- ##
===========================================
- Coverage 40.58% 40.57% -0.02%
===========================================
Files 791 799 +8
Lines 17901 18289 +388
Branches 1927 1959 +32
===========================================
+ Hits 7266 7421 +155
- Misses 10344 10571 +227
- Partials 291 297 +6
Flags with carried forward coverage won't be shown. Click here to find out more. |
629328d
to
810c366
Compare
810c366
to
1f07532
Compare
This PR currently has a merge conflict. Please resolve this and then re-add the |
As I've just catched the error mentioned in title, it seems that 5.1.2 version doesn't contain this fix. |
Proposed changes (including videos or screenshots)
Issue(s)
#26639
Steps to test or reproduce
Further comments
Some messages were coming with undefined replies, this was breaking some chat rooms. Adding a check to prevent the layout break.