Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Check if messsage.replies exist on new message template #26652

Merged
merged 12 commits into from
Sep 13, 2022

Conversation

filipemarins
Copy link
Contributor

@filipemarins filipemarins commented Aug 22, 2022

Proposed changes (including videos or screenshots)

Issue(s)

#26639

Steps to test or reproduce

Further comments

Some messages were coming with undefined replies, this was breaking some chat rooms. Adding a check to prevent the layout break.

@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #26652 (0b1a544) into develop (ddd1e87) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 0b1a544 differs from pull request most recent head ee0ed74. Consider uploading reports for the commit ee0ed74 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #26652      +/-   ##
===========================================
- Coverage    40.58%   40.57%   -0.02%     
===========================================
  Files          791      799       +8     
  Lines        17901    18289     +388     
  Branches      1927     1959      +32     
===========================================
+ Hits          7266     7421     +155     
- Misses       10344    10571     +227     
- Partials       291      297       +6     
Flag Coverage Δ
e2e 40.57% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

hugocostadev
hugocostadev previously approved these changes Aug 23, 2022
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Sep 1, 2022
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Sep 5, 2022
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Sep 5, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Sep 8, 2022
@kodiakhq kodiakhq bot merged commit 3c2679b into develop Sep 13, 2022
@shaymdev
Copy link

@d-gubert This and #26836 were was added to the 5.1.2 milestone this morning, but 5.1.2 was released a few days ago. Should it be a 5.1.3 milestone? Sorry if this is a dumb question. I'm just trying to learn about the release cycle around these parts. 😄

@krenuser
Copy link

krenuser commented Sep 21, 2022

As I've just catched the error mentioned in title, it seems that 5.1.2 version doesn't contain this fix.
Had to fix it manually again in prod sources 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants