Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add tests to cover issue fixed in #26720 #26767

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Conversation

murtaza98
Copy link
Contributor

(cherry picked from commit 3c2ec0e)

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

(cherry picked from commit 3c2ec0e)
@murtaza98 murtaza98 requested a review from a team as a code owner August 31, 2022 16:52
@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #26767 (2526462) into develop (717dc66) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #26767   +/-   ##
========================================
  Coverage    40.58%   40.59%           
========================================
  Files          799      799           
  Lines        18309    18309           
  Branches      1957     1957           
========================================
+ Hits          7431     7432    +1     
- Misses       10579    10580    +1     
+ Partials       299      297    -2     
Flag Coverage Δ
e2e 40.59% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman
Copy link
Contributor

Can you add tests for the endpoint in question to cover that too? 😬

@murtaza98
Copy link
Contributor Author

Can you add tests for the endpoint in question to cover that too? grimacing

@KevLehman I went with creating a separate PR for that save room info feature since it also needed migration from meteor method -> #26789

@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Sep 5, 2022
@ggazzo ggazzo merged commit 9a5604b into develop Sep 5, 2022
@ggazzo ggazzo deleted the reg/test-3c2ec0e branch September 5, 2022 15:28
@tassoevan tassoevan mentioned this pull request Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants