Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Livechat CurrentChats infinity re-rendering #27076

Merged
merged 4 commits into from
Oct 18, 2022
Merged

[FIX] Livechat CurrentChats infinity re-rendering #27076

merged 4 commits into from
Oct 18, 2022

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Oct 14, 2022 •
edited
Loading

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

OC-191

@codecov
Copy link

codecov bot commented Oct 14, 2022 •
edited
Loading

Codecov Report

Merging #27076 (e38be11) into develop (5f5730c) will increase coverage by 0.16%.
The diff coverage is n/a.

❗ Current head e38be11 differs from pull request most recent head 4402e56. Consider uploading reports for the commit 4402e56 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27076      +/-   ##
===========================================
+ Coverage    41.09%   41.25%   +0.16%     
===========================================
  Files          802      802              
  Lines        17819    17819              
  Branches      1972     1972              
===========================================
+ Hits          7322     7351      +29     
+ Misses       10200    10175      -25     
+ Partials       297      293       -4
Flag Coverage Δ
e2e 41.25% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp changed the title [FIX] Livechat room in CurrentChats not found redirecting to home page [FIX] Livechat CurrentChats infinity re-rendering Oct 17, 2022
@tiagoevanp tiagoevanp marked this pull request as ready for review October 17, 2022 14:28
@tiagoevanp tiagoevanp requested a review from a team as a code owner October 17, 2022 14:28
@ggazzo ggazzo added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Oct 18, 2022
@tiagoevanp tiagoevanp added this to the 5.3.0 milestone Oct 18, 2022
@kodiakhq kodiakhq bot merged commit f6bea29 into develop Oct 18, 2022
@kodiakhq kodiakhq bot deleted the fix/go-home-current-chats branch October 18, 2022 19:58
gabriellsh added a commit that referenced this pull request Oct 19, 2022
@gabriellsh
Merge branch 'develop' of github.com:RocketChat/Rocket.Chat into upda…
92e4e65 
…te/oembed

* 'develop' of github.com:RocketChat/Rocket.Chat:
  [FIX] Livechat CurrentChats infinity re-rendering (#27076)
  [NEW] Add new endpoint 'livechat/room.saveInfo' & deprecate 'livechat:saveInfo' meteor method (#26789)
MartinSchoeler pushed a commit that referenced this pull request Oct 25, 2022
@tiagoevanp @MartinSchoeler
[FIX] Livechat CurrentChats infinity re-rendering (#27076)
818bfd1
@ggazzo ggazzo mentioned this pull request Nov 1, 2022
Merged
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
@tiagoevanp @MartinSchoeler
[FIX] Livechat CurrentChats infinity re-rendering (#27076)
bc41640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksandernsilva aleksandernsilva aleksandernsilva approved these changes

Assignees
No one assigned
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tiagoevanp @aleksandernsilva @ggazzo