Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] CSS vars usage #27107

Merged
merged 41 commits into from
Oct 20, 2022
Merged

[FIX] CSS vars usage #27107

merged 41 commits into from
Oct 20, 2022

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Oct 20, 2022

basically we stop to use the old color palette and started using the semantic palette, it shouldn't just break anything BUT if you have any custom css it's interesting if you check what happens.

if something is broken, I'm sorry this is a little sad, but checking other versions I can't say when the customization was working 100%. That said, I don't have an optimal option: fix it or leave it as is.

That way I think we are less worse =/

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

juliajforesti and others added 30 commits September 15, 2022 10:43
@ggazzo ggazzo requested a review from a team as a code owner October 20, 2022 02:18
@lgtm-com
Copy link

lgtm-com bot commented Oct 20, 2022

This pull request introduces 2 alerts when merging 385af1f into 78e3ef1 - view on LGTM.com

new alerts:

  • 2 for Unused variable, import, function or class

@ggazzo ggazzo changed the title Chore: fuselage tokens [FIX] CSS vars usage Oct 20, 2022
@ggazzo ggazzo merged commit 7e43859 into develop Oct 20, 2022
@ggazzo ggazzo deleted the chore/fuselage-tokens branch October 20, 2022 04:10
MartinSchoeler pushed a commit that referenced this pull request Oct 25, 2022
Co-authored-by: Douglas Fabris <[email protected]>
Co-authored-by: juliajforesti <[email protected]>
@ggazzo ggazzo mentioned this pull request Nov 1, 2022
MartinSchoeler pushed a commit that referenced this pull request Nov 28, 2022
Co-authored-by: Douglas Fabris <[email protected]>
Co-authored-by: juliajforesti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants