-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] CSS vars usage #27107
Merged
Merged
[FIX] CSS vars usage #27107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t into feat/color-palette
Co-authored-by: Douglas Fabris <[email protected]>
…t.Chat into feat/color-palette-form
This pull request introduces 2 alerts when merging 385af1f into 78e3ef1 - view on LGTM.com new alerts:
|
MartinSchoeler
pushed a commit
that referenced
this pull request
Oct 25, 2022
Co-authored-by: Douglas Fabris <[email protected]> Co-authored-by: juliajforesti <[email protected]>
Merged
MartinSchoeler
pushed a commit
that referenced
this pull request
Nov 28, 2022
Co-authored-by: Douglas Fabris <[email protected]> Co-authored-by: juliajforesti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically we stop to use the old color palette and started using the semantic palette, it shouldn't just break anything BUT if you have any custom css it's interesting if you check what happens.
if something is broken, I'm sorry this is a little sad, but checking other versions I can't say when the customization was working 100%. That said, I don't have an optimal option: fix it or leave it as is.
That way I think we are less worse =/
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments