Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] User merge by e-mail on OAuth is case-sensitive #27167

Merged
merged 6 commits into from
Nov 7, 2022

Conversation

matheusbsilva137
Copy link
Member

Proposed changes (including videos or screenshots)

  • Ignore case when searching for a user by email.

Issue(s)

Fixes #22832

Steps to test or reproduce

  1. Manually register a user with an e-mail containing upper-case letters (eg [email protected]);
  2. Set up an OAuth server, enable the "Merge users" option and choose "Email" as the "Key Field";
  3. Using OAuth, try to login with a user with the same e-mail registered previously, but all in lower-case letter (eg [email protected]`);

Further comments

TC-80

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #27167 (5ebcdf3) into develop (91844b2) will increase coverage by 0.63%.
The diff coverage is 67.56%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27167      +/-   ##
===========================================
+ Coverage    41.02%   41.66%   +0.63%     
===========================================
  Files          833      826       -7     
  Lines        18407    18234     -173     
  Branches      2047     1987      -60     
===========================================
+ Hits          7552     7597      +45     
+ Misses       10568    10351     -217     
+ Partials       287      286       -1     
Flag Coverage Δ
e2e 41.66% <67.56%> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Nov 4, 2022
@alvaropmello alvaropmello added this to the 5.3.1 milestone Nov 7, 2022
@kodiakhq kodiakhq bot merged commit f3d488c into develop Nov 7, 2022
@kodiakhq kodiakhq bot deleted the case-insensitive-email-handling branch November 7, 2022 18:12
@ggazzo ggazzo mentioned this pull request Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA tested stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling of capital letters in account's email address
5 participants