Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: afterCreateUser callback missing roles info #30305

Closed
wants to merge 2 commits into from
Closed

Conversation

murtaza98
Copy link
Contributor

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2023

⚠️ No Changeset found

Latest commit: e574732

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #30305 (e574732) into develop (3245a0a) will decrease coverage by 0.14%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30305      +/-   ##
===========================================
- Coverage    48.38%   48.25%   -0.14%     
===========================================
  Files          700      700              
  Lines        13039    13039              
  Branches      2318     2318              
===========================================
- Hits          6309     6292      -17     
- Misses        6372     6389      +17     
  Partials       358      358              
Flag Coverage Δ
e2e 48.20% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@murtaza98 murtaza98 changed the title fix: afterUserCreated callback not being triggered by users.create API fix: afterCreate callback missing roles info Sep 6, 2023
@murtaza98 murtaza98 changed the title fix: afterCreate callback missing roles info fix: afterCreateUser callback missing roles info Sep 6, 2023
@murtaza98
Copy link
Contributor Author

Closing in favour of Kevin's PR -> #30309

@murtaza98 murtaza98 closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants