Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: more Hindi translation keys added #30927

Merged
merged 6 commits into from
Aug 15, 2024

Conversation

its-kunal
Copy link
Contributor

@its-kunal its-kunal commented Nov 11, 2023

Proposed changes (including videos or screenshots)

Added translation more translation keys for hindi language.

Issue(s)

Closes #30892
Closes #32786

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Nov 11, 2023

⚠️ No Changeset found

Latest commit: 331a06f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@its-kunal
Copy link
Contributor Author

Hey @MartinSchoeler Please review my pull request. #30927

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8677f15) 59.39% compared to head (a69dd17) 49.35%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #30927       +/-   ##
============================================
- Coverage    59.39%   49.35%   -10.05%     
============================================
  Files         1793     3310     +1517     
  Lines        34909    81343    +46434     
  Branches      7246    16659     +9413     
============================================
+ Hits         20734    40143    +19409     
- Misses       12573    36498    +23925     
- Partials      1602     4702     +3100     
Flag Coverage Δ
e2e 52.54% <ø> (-0.03%) ⬇️
e2e-api 40.65% <ø> (?)
unit 76.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@its-kunal
Copy link
Contributor Author

@MartinSchoeler When will this PR get merged?

@dougfabris dougfabris changed the title i18n: more Hindi translation keys added, Fixes issue - #30892 i18n: more Hindi translation keys added Jan 4, 2024
@its-kunal
Copy link
Contributor Author

Hey @reetp , can you please review my PR.

Copy link
Member

@scuciatto scuciatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @its-kunal . Thanks for this contribution. Can you please fix the conflicts so we can review it?

Also, you can contribute to translations using Duolingo. It's a faster way to do it, since the merges are automated and the translations added to new releses. If you want an invite to lingohub, please send me an e-mail (felipe.scuciatto[at]rocket.chat )

@its-kunal
Copy link
Contributor Author

Ok, I'll soon resolve the conflicts.

dougfabris
dougfabris previously approved these changes Aug 9, 2024
@dougfabris dougfabris added this to the 6.12 milestone Aug 9, 2024
Copy link
Contributor

dionisio-bot bot commented Aug 9, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@dougfabris dougfabris force-pushed the hi-translation branch 2 times, most recently from 4e3f2a1 to 56a474c Compare August 13, 2024 14:31
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Aug 15, 2024
@ggazzo ggazzo merged commit 77989f5 into RocketChat:develop Aug 15, 2024
46 checks passed
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Co-authored-by: Douglas Fabris <[email protected]>
Co-authored-by: Guilherme Gazzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
communityPR stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hindi Language Translation Backlog in UI Some of the translation keys are missing in Hindi translation
6 participants