feat: new apps logger deno-runtime #31136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/apps-deno-runtime #31136 +/- ##
==========================================================
+ Coverage 49.46% 53.40% +3.94%
==========================================================
Files 3312 1491 -1821
Lines 81368 29400 -51968
Branches 16657 5959 -10698
==========================================================
- Hits 40249 15702 -24547
+ Misses 36415 12586 -23829
+ Partials 4704 1112 -3592
Flags with carried forward coverage won't be shown. Click here to find out more. |
d-gubert
force-pushed
the
feat/apps-logger
branch
from
5830978
to
fa15b90
Compare
tapiarafael
force-pushed
the
feat/apps-logger
branch
from
ef33464
to
c91fde0
Compare
d-gubert
approved these changes
Jan 11, 2024
|
Tests are going to be failing for now, merging it to the feature branch |
d-gubert
added a commit
that referenced
this pull request
Jan 30, 2024
* refactor: convert to typescript * feat: change storeEntries to receive logEntries instead appconsole instance * refactor: remove `logs-storage.js` * refactor: remove type `any` * fix: type errors * fix: implement correct method * chore: use apps engine with deno vm * Fix import --------- Co-authored-by: Douglas Gubert <[email protected]>
d-gubert
added a commit
that referenced
this pull request
Feb 22, 2024
* refactor: convert to typescript * feat: change storeEntries to receive logEntries instead appconsole instance * refactor: remove `logs-storage.js` * refactor: remove type `any` * fix: type errors * fix: implement correct method * chore: use apps engine with deno vm * Fix import --------- Co-authored-by: Douglas Gubert <[email protected]>
d-gubert
added a commit
that referenced
this pull request
Mar 14, 2024
* refactor: convert to typescript * feat: change storeEntries to receive logEntries instead appconsole instance * refactor: remove `logs-storage.js` * refactor: remove type `any` * fix: type errors * fix: implement correct method * chore: use apps engine with deno vm * Fix import --------- Co-authored-by: Douglas Gubert <[email protected]>
d-gubert
added a commit
that referenced
this pull request
Mar 16, 2024
* refactor: convert to typescript * feat: change storeEntries to receive logEntries instead appconsole instance * refactor: remove `logs-storage.js` * refactor: remove type `any` * fix: type errors * fix: implement correct method * chore: use apps engine with deno vm * Fix import --------- Co-authored-by: Douglas Gubert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
Depends on RocketChat/Rocket.Chat.Apps-engine#674