feat(UiKit): Users select

[tiagoevanp]

This PR introduces new input components to UiKit:

• Multiple Users Select
• Single User Select

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

CORE-59

[changeset-bot]

🦋 Changeset detected

Latest commit: 719635a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages

Name	Type
@rocket.chat/fuselage-ui-kit	Major
@rocket.chat/ui-kit	Minor
@rocket.chat/meteor	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/core-services	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/livechat	Patch
@rocket.chat/rest-typings	Patch
rocketchat-services	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/presence	Patch
@rocket.chat/apps	Patch
@rocket.chat/cron	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.23%. Comparing base (526cbf1) to head (719635a).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #31455      +/-   ##
===========================================
- Coverage    56.24%   56.23%   -0.01%     
===========================================
  Files         2428     2428              
  Lines        53560    53560              
  Branches     11031    11031              
===========================================
- Hits         30124    30122       -2     
- Misses       20798    20832      +34     
+ Partials      2638     2606      -32     

Flag	Coverage Δ
unit	72.30% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

[gabriellsh]

I actually had several other changes to request, but there's a bigger issue that I noticed upon further. Some (if not all) of the components created for the fuselage-ui-kit package, are copies of other existing components that are already in use. Even some comments have been copied over, as well as API calls (some have minor changes).

This feels a little strange to me, as we should not be copying implementation like this. Even more so because there are some implementation flaws on these components (like irrelevant useMemos and some weird logic) that was not modified/removed/improved in any sort of form. Could you explain the reasoning behind this? Is there any way we could improve this by reusing the same components?

Also, are we expecting that federated users will be shown in apps? I think this should be discussed since federated users have some limitations on how they work compared to regular users.

Btw, I know this is already a little too critic, but the name chosen for the components Multi....Multiple, doesn't it seem a little... redundant?

[tiagoevanp]

In fact, I was copying core implementations, thanks to raise the points where my eyes passed by without notice some of the dumb errors... I will correct them ASAP. Another important thing to mention is: I know that we don't have a perfect autocomplete/select component to use, and we have a lot of different implementations of it in so many parts of the code. I already have created a different task to create a separated package for users/channel selectors who should centralize all... like ui-selects, or something else! I received a negative from another teammate because there is more than a simple work on doing this, regarding fuselage work for select components as well 😬. So, my first option to make some progress was the copycat technique, and wait for future improvements on this side.