Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): Rewrite AppMenu to TypeScript #31533

Merged
merged 15 commits into from
Apr 30, 2024

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jan 25, 2024

Proposed changes (including videos or screenshots)

This is a rewrite of AppMenu from Javascript to Typescript.

Important note: there are a lot of possible changes in code enhancement but I chose to deliver the PR as a simple language migration well typed.

Issue(s)

Steps to test or reproduce

Further comments

CORE-241

Copy link

changeset-bot bot commented Jan 25, 2024

⚠️ No Changeset found

Latest commit: b5007fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: Patch coverage is 69.51872% with 57 lines in your changes are missing coverage. Please review.

Project coverage is 55.55%. Comparing base (6205ef1) to head (b5007fa).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31533      +/-   ##
===========================================
+ Coverage    55.53%   55.55%   +0.01%     
===========================================
  Files         2375     2406      +31     
  Lines        52109    52881     +772     
  Branches     10657    10860     +203     
===========================================
+ Hits         28940    29378     +438     
- Misses       20633    20896     +263     
- Partials      2536     2607      +71     
Flag Coverage Δ
e2e 54.82% <ø> (+0.04%) ⬆️
unit 73.49% <69.51%> (-1.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp marked this pull request as ready for review January 30, 2024 18:26
@tiagoevanp tiagoevanp requested review from a team as code owners January 30, 2024 18:26
@casalsgh casalsgh modified the milestone: 6.7 Feb 9, 2024
@tassoevan tassoevan added this to the 6.7 milestone Feb 27, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 27, 2024
@tassoevan tassoevan changed the title chore: Rewrite AppMenu.js to TypeScript refactor(client): Rewrite AppMenu to TypeScript Feb 27, 2024
@scuciatto scuciatto modified the milestones: 6.7, 7.0 Mar 6, 2024
@ggazzo ggazzo modified the milestones: 7.0, 6.8 Apr 9, 2024
Copy link
Contributor

dionisio-bot bot commented Apr 9, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA skipped labels Apr 9, 2024
Copy link
Contributor

kodiakhq bot commented Apr 14, 2024

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 14, 2024
@RocketChat RocketChat deleted a comment from dionisio-bot bot Apr 15, 2024
apps/meteor/client/components/GenericMenu/GenericMenu.tsx Outdated Show resolved Hide resolved
apps/meteor/client/views/marketplace/AppMenu.tsx Outdated Show resolved Hide resolved
apps/meteor/client/views/marketplace/hooks/useAppMenu.tsx Outdated Show resolved Hide resolved
@tiagoevanp tiagoevanp modified the milestones: 6.8, 7.0 Apr 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Apr 22, 2024
@scuciatto scuciatto modified the milestones: 7.0, 6.9 Apr 23, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Apr 24, 2024
@ggazzo ggazzo force-pushed the rewrite/marketplace-app-menu branch from 08352ff to 731bae3 Compare April 26, 2024 18:06
@ggazzo ggazzo merged commit 972b5b8 into develop Apr 30, 2024
43 checks passed
@ggazzo ggazzo deleted the rewrite/marketplace-app-menu branch April 30, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants