Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Looking at the user's permission before rendering the 'Start Call' button on UserInfo #31600

Merged
merged 5 commits into from
Feb 5, 2024

Conversation

Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Feb 1, 2024

This solves an akward mismatch of the permissions, since we cannot start a call if we don't have the according permissions, but the button shows nonetheless, which is misleading.

Proposed changes (including videos or screenshots)

Looking at the workspace setting called: VideoConf_Enable_DMs
Also looking at the user permission called: call-management
For a user to be able to call someone both of those should be enabled

Issue(s)

Steps to test or reproduce

  1. Remove the Call Management permission from the user;
  2. Settings > Conference call > Enable in direct messages = Disabled;
  3. Open a new DM with the user
  4. Click on the 'User Info' icon

Expected Behavior: It should not show the 'Start Call' button

if either of 'Call Management' or 'Enable in direct messages' are disabled the button won't appear, but if both of those are set the 'Start Call' button should appear and work correctly

Further comments

SUP-470

Copy link

changeset-bot bot commented Feb 1, 2024

🦋 Changeset detected

Latest commit: 4c9d1e7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c2ca061) 53.62% compared to head (4c9d1e7) 54.35%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31600      +/-   ##
===========================================
+ Coverage    53.62%   54.35%   +0.73%     
===========================================
  Files         2255     2280      +25     
  Lines        49774    50154     +380     
  Branches     10170    10234      +64     
===========================================
+ Hits         26692    27262     +570     
+ Misses       20641    20408     -233     
- Partials      2441     2484      +43     
Flag Coverage Δ
e2e 53.19% <50.00%> (+1.42%) ⬆️
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb marked this pull request as ready for review February 1, 2024 13:34
@Gustrb Gustrb requested a review from a team as a code owner February 1, 2024 13:34
Copy link
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ggazzo
Copy link
Member

ggazzo commented Feb 1, 2024

this is a fix: not a feat:

@ggazzo ggazzo changed the title feat: Looking at the user's permission before rendering the 'Start Call' button on UserInfo fix: Looking at the user's permission before rendering the 'Start Call' button on UserInfo Feb 1, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 5, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 5, 2024
@kodiakhq kodiakhq bot merged commit ed45125 into develop Feb 5, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the fix/show-start-call-when-allowed branch February 5, 2024 17:27
@scuciatto scuciatto added this to the 6.7 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants