-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Looking at the user's permission before rendering the 'Start Call' button on UserInfo #31600
Conversation
🦋 Changeset detectedLatest commit: 4c9d1e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #31600 +/- ##
===========================================
+ Coverage 53.62% 54.35% +0.73%
===========================================
Files 2255 2280 +25
Lines 49774 50154 +380
Branches 10170 10234 +64
===========================================
+ Hits 26692 27262 +570
+ Misses 20641 20408 -233
- Partials 2441 2484 +43
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
this is a |
This solves an akward mismatch of the permissions, since we cannot start a call if we don't have the according permissions, but the button shows nonetheless, which is misleading.
Proposed changes (including videos or screenshots)
Looking at the workspace setting called: VideoConf_Enable_DMs
Also looking at the user permission called: call-management
For a user to be able to call someone both of those should be enabled
Issue(s)
Steps to test or reproduce
Expected Behavior: It should not show the 'Start Call' button
if either of 'Call Management' or 'Enable in direct messages' are disabled the button won't appear, but if both of those are set the 'Start Call' button should appear and work correctly
Further comments
SUP-470