Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make channels api tests fully independent #31606

Merged
merged 6 commits into from
Feb 5, 2024

Conversation

MarcosSpessatto
Copy link
Member

@MarcosSpessatto MarcosSpessatto commented Feb 1, 2024

https://rocketchat.atlassian.net/browse/CORE-147

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner February 1, 2024 19:12
Copy link

changeset-bot bot commented Feb 1, 2024

⚠️ No Changeset found

Latest commit: 5207959

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4442737) 54.35% compared to head (5207959) 54.38%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31606      +/-   ##
===========================================
+ Coverage    54.35%   54.38%   +0.03%     
===========================================
  Files         2276     2280       +4     
  Lines        50102    50151      +49     
  Branches     10226    10233       +7     
===========================================
+ Hits         27232    27276      +44     
- Misses       20386    20396      +10     
+ Partials      2484     2479       -5     
Flag Coverage Δ
e2e 53.26% <ø> (+0.10%) ⬆️
e2e-api 39.86% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@sampaiodiego sampaiodiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the diff didn't help in this case 🙈 I guess it is ok 😬

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 5, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 5, 2024
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Feb 5, 2024
@kodiakhq kodiakhq bot merged commit de6997e into develop Feb 5, 2024
45 checks passed
@kodiakhq kodiakhq bot deleted the test/decouple-channels branch February 5, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants